From 8ae5afe2d231dd15b94d8864e897796944b53319 Mon Sep 17 00:00:00 2001 From: Sebastian Plesciuc Date: Fri, 21 Apr 2017 18:05:28 +0300 Subject: [PATCH] test: dynamic port in cluster ipc throw Removed common.PORT from test-cluster-ipc-throw to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: https://github.com/nodejs/node/pull/12571 Ref: https://github.com/nodejs/node/issues/12376 Reviewed-By: James M Snell Reviewed-By: Richard Lau Reviewed-By: Santiago Gimeno Reviewed-By: Luigi Pinca --- test/parallel/test-cluster-ipc-throw.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-cluster-ipc-throw.js b/test/parallel/test-cluster-ipc-throw.js index f2e7f2822c7315..95c5d84ea6dbb0 100644 --- a/test/parallel/test-cluster-ipc-throw.js +++ b/test/parallel/test-cluster-ipc-throw.js @@ -2,20 +2,23 @@ const common = require('../common'); const http = require('http'); const cluster = require('cluster'); +const assert = require('assert'); cluster.schedulingPolicy = cluster.SCHED_RR; const server = http.createServer(); if (cluster.isMaster) { - server.listen(common.PORT); - const worker = cluster.fork(); - worker.on('exit', common.mustCall(() => { - server.close(); + server.listen({port: 0}, common.mustCall(() => { + const worker = cluster.fork({PORT: server.address().port}); + worker.on('exit', common.mustCall(() => { + server.close(); + })); })); } else { + assert(process.env.PORT); process.on('uncaughtException', common.mustCall((e) => {})); - server.listen(common.PORT); + server.listen(process.env.PORT); server.on('error', common.mustCall((e) => { cluster.worker.disconnect(); throw e;