From 82ceb5e4b1f0114361fca617799caa04725bee1b Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 29 Nov 2018 09:21:06 +0100 Subject: [PATCH] test: minor refactoring of onticketkeycallback The motivation for this commit is to make the the onticketkeycallback function more readable. PR-URL: https://github.com/nodejs/node/pull/24718 Reviewed-By: Jon Moss Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- test/parallel/test-https-resume-after-renew.js | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/test/parallel/test-https-resume-after-renew.js b/test/parallel/test-https-resume-after-renew.js index 5a621e8f561829..939975adfa6efb 100644 --- a/test/parallel/test-https-resume-after-renew.js +++ b/test/parallel/test-https-resume-after-renew.js @@ -22,16 +22,13 @@ const hmac = Buffer.alloc(16, 'H'); server._sharedCreds.context.enableTicketKeyCallback(); server._sharedCreds.context.onticketkeycallback = function(name, iv, enc) { - let newName, newIV; if (enc) { - newName = Buffer.alloc(16, 'A'); - newIV = crypto.randomBytes(16); - } else { - // Renew - return [ 2, hmac, aes ]; + const newName = Buffer.alloc(16, 'A'); + const newIV = crypto.randomBytes(16); + return [ 1, hmac, aes, newName, newIV ]; } - - return [ 1, hmac, aes, newName, newIV ]; + // Renew + return [ 2, hmac, aes ]; }; server.listen(0, function() {