From 7fee207ff763209fad0041c387fc52ee22333b05 Mon Sep 17 00:00:00 2001 From: Brian White Date: Fri, 1 May 2015 11:53:00 -0400 Subject: [PATCH] http: simplify code and remove unused properties --- lib/_http_common.js | 6 ------ lib/_http_incoming.js | 10 +++++++--- lib/_http_outgoing.js | 1 - 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/_http_common.js b/lib/_http_common.js index 7861848b46a9d4..757032929444b1 100644 --- a/lib/_http_common.js +++ b/lib/_http_common.js @@ -126,12 +126,6 @@ function parserOnMessageComplete() { parser._url = ''; } - if (!stream.upgrade) - // For upgraded connections, also emit this after parser.execute - stream.push(null); - } - - if (stream && !parser.incoming._pendings.length) { // For emit end event stream.push(null); } diff --git a/lib/_http_incoming.js b/lib/_http_incoming.js index 41ece371cdfbe6..8c4c303d1741ca 100644 --- a/lib/_http_incoming.js +++ b/lib/_http_incoming.js @@ -38,8 +38,6 @@ function IncomingMessage(socket) { this.readable = true; - this._pendings = []; - this._pendingIndex = 0; this.upgrade = null; // request (server) only @@ -49,7 +47,6 @@ function IncomingMessage(socket) { // response (client) only this.statusCode = null; this.statusMessage = null; - this.client = this.socket; // flag for backwards compatibility grossness. this._consuming = false; @@ -63,6 +60,13 @@ util.inherits(IncomingMessage, Stream.Readable); exports.IncomingMessage = IncomingMessage; +Object.defineProperty(IncomingMessage.prototype, 'client', { + configurable: true, + enumerable: true, + get: util.deprecate(function() { + return this.socket; + }, 'client is deprecated, use socket or connection instead') +}); IncomingMessage.prototype.setTimeout = function(msecs, callback) { if (callback) diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js index 88590551c9defb..76f3435920b689 100644 --- a/lib/_http_outgoing.js +++ b/lib/_http_outgoing.js @@ -62,7 +62,6 @@ function OutgoingMessage() { this._trailer = ''; this.finished = false; - this._hangupClose = false; this._headerSent = false; this.socket = null;