From 7f46867f50b27275e17fbb0e95cdb69a64cdcea6 Mon Sep 17 00:00:00 2001 From: Jenna Vuong Date: Sat, 24 Sep 2016 20:44:36 -0700 Subject: [PATCH] test: cleanup parallel/test-file-write-stream2.js replace ==, !=, some instances of var, and assert.equal() PR-URL: https://github.com/nodejs/node/pull/8770 Reviewed-By: Colin Ihrig Reviewed-By: Teddy Katz Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Ilkka Myller --- test/parallel/test-file-write-stream2.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/parallel/test-file-write-stream2.js b/test/parallel/test-file-write-stream2.js index 6f0ccedb07aea1..69fdb7051ff11c 100644 --- a/test/parallel/test-file-write-stream2.js +++ b/test/parallel/test-file-write-stream2.js @@ -9,9 +9,9 @@ var fs = require('fs'); var filepath = path.join(common.tmpDir, 'write.txt'); var file; -var EXPECTED = '012345678910'; +const EXPECTED = '012345678910'; -var cb_expected = 'write open drain write drain close error '; +const cb_expected = 'write open drain write drain close error '; var cb_occurred = ''; var countDrains = 0; @@ -48,7 +48,7 @@ file = fs.createWriteStream(filepath, { file.on('open', function(fd) { console.error('open'); cb_occurred += 'open '; - assert.equal(typeof fd, 'number'); + assert.strictEqual(typeof fd, 'number'); }); file.on('drain', function() { @@ -57,12 +57,12 @@ file.on('drain', function() { ++countDrains; if (countDrains === 1) { console.error('drain=1, write again'); - assert.equal(fs.readFileSync(filepath, 'utf8'), EXPECTED); + assert.strictEqual(fs.readFileSync(filepath, 'utf8'), EXPECTED); console.error('ondrain write ret=%j', file.write(EXPECTED)); cb_occurred += 'write '; - } else if (countDrains == 2) { + } else if (countDrains === 2) { console.error('second drain, end'); - assert.equal(fs.readFileSync(filepath, 'utf8'), EXPECTED + EXPECTED); + assert.strictEqual(fs.readFileSync(filepath, 'utf8'), EXPECTED + EXPECTED); file.end(); } }); @@ -85,6 +85,6 @@ for (var i = 0; i < 11; i++) { console.error('%d %j', i, ret); // return false when i hits 10 - assert.strictEqual(ret, i != 10); + assert.strictEqual(ret, i !== 10); } cb_occurred += 'write ';