From 7d2b08a3b55ef46719436a1445e207e34d6a355d Mon Sep 17 00:00:00 2001 From: Mandeep Singh Date: Sun, 26 Nov 2017 23:09:28 +0530 Subject: [PATCH] test: use countdown timer PR-URL: https://github.com/nodejs/node/pull/17326 Refs: https://github.com/nodejs/node/issues/17169 Reviewed-By: Jon Moss Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- test/parallel/test-http-response-status-message.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/test/parallel/test-http-response-status-message.js b/test/parallel/test-http-response-status-message.js index e52abc57e6ce54..0f9bce8fa87d67 100644 --- a/test/parallel/test-http-response-status-message.js +++ b/test/parallel/test-http-response-status-message.js @@ -24,8 +24,7 @@ require('../common'); const assert = require('assert'); const http = require('http'); const net = require('net'); - -let testsComplete = 0; +const Countdown = require('../common/countdown'); const testCases = [ { path: '/200', statusMessage: 'OK', @@ -59,6 +58,8 @@ const server = net.createServer(function(connection) { }); }); +const countdown = new Countdown(testCases.length, () => server.close()); + function runTest(testCaseIndex) { const testCase = testCases[testCaseIndex]; @@ -71,12 +72,9 @@ function runTest(testCaseIndex) { assert.strictEqual(testCase.statusMessage, response.statusMessage); response.on('end', function() { - testsComplete++; - + countdown.dec(); if (testCaseIndex + 1 < testCases.length) { runTest(testCaseIndex + 1); - } else { - server.close(); } }); @@ -85,7 +83,3 @@ function runTest(testCaseIndex) { } server.listen(0, function() { runTest(0); }); - -process.on('exit', function() { - assert.strictEqual(testCases.length, testsComplete); -});