From 6e86a70da2f54bd68cc5a8038a5d6940d6a4fce9 Mon Sep 17 00:00:00 2001 From: kuroljov Date: Sun, 2 Jul 2017 23:48:47 +0300 Subject: [PATCH] assert: replace many if's with if-else statement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace multiple mutually exclusive `if` statements with if-else statements. PR-URL: https://github.com/nodejs/node/pull/14043 Reviewed-By: Refael Ackermann Reviewed-By: Franziska Hinkelmann Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: David Cai --- lib/assert.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/assert.js b/lib/assert.js index 04b742c19a063a..902bb82ce2b113 100644 --- a/lib/assert.js +++ b/lib/assert.js @@ -62,18 +62,20 @@ function innerFail(actual, expected, message, operator, stackStartFunction) { } function fail(actual, expected, message, operator, stackStartFunction) { - if (arguments.length === 0) { + const argsLen = arguments.length; + + if (argsLen === 0) { message = 'Failed'; - } - if (arguments.length === 1) { + } else if (argsLen === 1) { message = actual; actual = undefined; - } - if (arguments.length === 2) { + } else if (argsLen === 2) { operator = '!='; } + innerFail(actual, expected, message, operator, stackStartFunction || fail); } + assert.fail = fail; // The AssertionError is defined in internal/error.