From 6ce26c8c8b6feedec2693948e63afb6c722bd28d Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 31 May 2016 15:55:08 -0700
Subject: [PATCH] test: add test for uid/gid setting in spawn

Remove a disabled test in favor of one that expects an error.

This validates (somewhat) that the underlying code is calling the
correct system call for setting UID and GID. Unlike the formerly
disabled test, it does not try to validate that the system UID/GID
setting works.

PR-URL: https://github.com/nodejs/node/pull/7084
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/disabled/test-child-process-uid-gid.js | 60 ---------------------
 test/parallel/test-child-process-uid-gid.js | 14 +++++
 2 files changed, 14 insertions(+), 60 deletions(-)
 delete mode 100644 test/disabled/test-child-process-uid-gid.js
 create mode 100644 test/parallel/test-child-process-uid-gid.js

diff --git a/test/disabled/test-child-process-uid-gid.js b/test/disabled/test-child-process-uid-gid.js
deleted file mode 100644
index 90708bc2ca4016..00000000000000
--- a/test/disabled/test-child-process-uid-gid.js
+++ /dev/null
@@ -1,60 +0,0 @@
-'use strict';
-var common = require('../common');
-var assert = require('assert');
-var spawn = require('child_process').spawn;
-var fs = require('fs');
-
-var myUid = process.getuid();
-var myGid = process.getgid();
-
-if (myUid != 0) {
-  console.error('must be run as root, otherwise the gid/uid setting will' +
-                ' fail.');
-  process.exit(1);
-}
-
-// get a different user.
-// don't care who it is, as long as it's not root
-var passwd = fs.readFileSync('/etc/passwd', 'utf8');
-passwd = passwd.trim().split(/\n/);
-
-for (var i = 0, l = passwd.length; i < l; i++) {
-  if (passwd[i].charAt(0) === '#') continue;
-  passwd[i] = passwd[i].split(':');
-  var otherName = passwd[i][0];
-  var otherUid = +passwd[i][2];
-  var otherGid = +passwd[i][3];
-  if (otherUid && otherUid !== myUid &&
-      otherGid && otherGid !== myGid &&
-      otherUid > 0) {
-    break;
-  }
-}
-if (!otherUid && !otherGid) throw new Error('failed getting passwd info.');
-
-console.error('name, id, gid = %j', [otherName, otherUid, otherGid]);
-
-var whoNumber = spawn('id', [], { uid: otherUid, gid: otherGid });
-var whoName = spawn('id', [], { uid: otherName, gid: otherGid });
-
-whoNumber.stdout.buf = 'byNumber:';
-whoName.stdout.buf = 'byName:';
-whoNumber.stdout.on('data', onData);
-whoName.stdout.on('data', onData);
-function onData(c) { this.buf += c; }
-
-whoNumber.on('exit', onExit);
-whoName.on('exit', onExit);
-
-function onExit(code) {
-  var buf = this.stdout.buf;
-  console.log(buf);
-  var expr = new RegExp('^(byName|byNumber):uid=' +
-                        otherUid +
-                        '\\(' +
-                        otherName +
-                        '\\) gid=' +
-                        otherGid +
-                        '\\(');
-  assert.ok(buf.match(expr), 'uid and gid should match ' + otherName);
-}
diff --git a/test/parallel/test-child-process-uid-gid.js b/test/parallel/test-child-process-uid-gid.js
new file mode 100644
index 00000000000000..220cae633e112f
--- /dev/null
+++ b/test/parallel/test-child-process-uid-gid.js
@@ -0,0 +1,14 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const spawn = require('child_process').spawn;
+
+const expectedError = common.isWindows ? /\bENOTSUP\b/ : /\bEPERM\b/;
+
+assert.throws(() => {
+  spawn('echo', ['fhqwhgads'], {uid: 0});
+}, expectedError);
+
+assert.throws(() => {
+  spawn('echo', ['fhqwhgads'], {gid: 0});
+}, expectedError);