diff --git a/common.gypi b/common.gypi index 5e75a899ae8cfb..9e52bb1d97ece8 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.10', + 'v8_embedder_string': '-node.11', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/include/v8-embedder-state-scope.h b/deps/v8/include/v8-embedder-state-scope.h index 6ae9b3b4779bf7..37e1f2bacb71f8 100644 --- a/deps/v8/include/v8-embedder-state-scope.h +++ b/deps/v8/include/v8-embedder-state-scope.h @@ -32,6 +32,8 @@ class V8_EXPORT EmbedderStateScope { EmbedderStateScope(Isolate* isolate, Local context, EmbedderStateTag tag); + ~EmbedderStateScope(); + private: // Declaring operator new and delete as deleted is not spec compliant. // Therefore declare them private instead to disable dynamic alloc diff --git a/deps/v8/src/api/api.cc b/deps/v8/src/api/api.cc index 7e9c504f8e7e2c..a71dd1670ce623 100644 --- a/deps/v8/src/api/api.cc +++ b/deps/v8/src/api/api.cc @@ -10361,6 +10361,11 @@ EmbedderStateScope::EmbedderStateScope(Isolate* isolate, EmbedderStateTag tag) : embedder_state_(new internal::EmbedderState(isolate, context, tag)) {} +// std::unique_ptr's destructor is not compatible with Forward declared +// EmbedderState class. +// Default destructor must be defined in implementation file. +EmbedderStateScope::~EmbedderStateScope() = default; + void TracedReferenceBase::CheckValue() const { #ifdef V8_HOST_ARCH_64_BIT if (!val_) return;