From 47a252257bd1d11046b233b2806cfed8ad0f6e92 Mon Sep 17 00:00:00 2001
From: theanarkh <theratliter@gmail.com>
Date: Wed, 22 Jun 2022 22:10:18 +0800
Subject: [PATCH] net: fix net.Server keepalive and noDelay

PR-URL: https://github.com/nodejs/node/pull/43497
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
---
 lib/net.js                                 |  9 ++++----
 test/parallel/test-net-server-keepalive.js | 25 ++++++++++++++++++++++
 test/parallel/test-net-server-nodelay.js   | 23 ++++++++++++++++++++
 3 files changed, 52 insertions(+), 5 deletions(-)
 create mode 100644 test/parallel/test-net-server-keepalive.js
 create mode 100644 test/parallel/test-net-server-nodelay.js

diff --git a/lib/net.js b/lib/net.js
index 2e0b26a19585c2..f72a745bcc7ef3 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -1659,12 +1659,11 @@ function onconnection(err, clientHandle) {
     writable: true
   });
 
-  if (self.noDelay && handle.setNoDelay) {
-    handle.setNoDelay(true);
+  if (self.noDelay && clientHandle.setNoDelay) {
+    clientHandle.setNoDelay(true);
   }
-
-  if (self.keepAlive && self.setKeepAlive) {
-    handle.setKeepAlive(true, handle.keepAliveInitialDelay);
+  if (self.keepAlive && clientHandle.setKeepAlive) {
+    clientHandle.setKeepAlive(true, self.keepAliveInitialDelay);
   }
 
   self._connections++;
diff --git a/test/parallel/test-net-server-keepalive.js b/test/parallel/test-net-server-keepalive.js
new file mode 100644
index 00000000000000..384787d22bb69c
--- /dev/null
+++ b/test/parallel/test-net-server-keepalive.js
@@ -0,0 +1,25 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+const server = net.createServer({
+  keepAlive: true,
+  keepAliveInitialDelay: 1000
+}, common.mustCall((socket) => {
+  socket.destroy();
+  server.close();
+})).listen(0, common.mustCall(() => {
+  net.connect(server.address().port);
+}));
+
+const onconnection = server._handle.onconnection;
+server._handle.onconnection = common.mustCall((err, clientHandle) => {
+  const setKeepAlive = clientHandle.setKeepAlive;
+  clientHandle.setKeepAlive = common.mustCall((enable, initialDelayMsecs) => {
+    assert.strictEqual(enable, server.keepAlive);
+    assert.strictEqual(initialDelayMsecs, server.keepAliveInitialDelay);
+    setKeepAlive.call(clientHandle, enable, initialDelayMsecs);
+  });
+  onconnection.call(server._handle, err, clientHandle);
+});
diff --git a/test/parallel/test-net-server-nodelay.js b/test/parallel/test-net-server-nodelay.js
new file mode 100644
index 00000000000000..f5ee77f71c5383
--- /dev/null
+++ b/test/parallel/test-net-server-nodelay.js
@@ -0,0 +1,23 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+const server = net.createServer({
+  noDelay: true
+}, common.mustCall((socket) => {
+  socket.destroy();
+  server.close();
+})).listen(0, common.mustCall(() => {
+  net.connect(server.address().port);
+}));
+
+const onconnection = server._handle.onconnection;
+server._handle.onconnection = common.mustCall((err, clientHandle) => {
+  const setNoDelay = clientHandle.setNoDelay;
+  clientHandle.setNoDelay = common.mustCall((enable) => {
+    assert.strictEqual(enable, server.noDelay);
+    setNoDelay.call(clientHandle, enable);
+  });
+  onconnection.call(server._handle, err, clientHandle);
+});