From 17b8381585d1b1e257de47871e2f15f24ebf9f7f Mon Sep 17 00:00:00 2001 From: Brian White Date: Mon, 15 Aug 2016 13:43:50 -0400 Subject: [PATCH] net: remove unnecessary variables V8 is smart enough to optimize the length property checking when iterating over an array with a for loop. PR-URL: https://github.com/nodejs/node/pull/8112 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Evan Lucas Reviewed-By: James M Snell --- lib/net.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/net.js b/lib/net.js index ad799567b094c1..ca220e4725aaa6 100644 --- a/lib/net.js +++ b/lib/net.js @@ -60,9 +60,8 @@ exports.createServer = function(options, connectionListener) { // connect(path, [cb]); // exports.connect = exports.createConnection = function() { - const argsLen = arguments.length; - var args = new Array(argsLen); - for (var i = 0; i < argsLen; i++) + var args = new Array(arguments.length); + for (var i = 0; i < arguments.length; i++) args[i] = arguments[i]; args = normalizeConnectArgs(args); debug('createConnection', args); @@ -885,9 +884,8 @@ Socket.prototype.connect = function(options, cb) { // Old API: // connect(port, [host], [cb]) // connect(path, [cb]); - const argsLen = arguments.length; - var args = new Array(argsLen); - for (var i = 0; i < argsLen; i++) + var args = new Array(arguments.length); + for (var i = 0; i < arguments.length; i++) args[i] = arguments[i]; args = normalizeConnectArgs(args); return Socket.prototype.connect.apply(this, args);