Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate longevity test #1657

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Automate longevity test #1657

merged 5 commits into from
Mar 11, 2024

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Mar 7, 2024

Problem: NFR tests are a burden to run manually, taking a lot of time and effort.

Solution: Automate the longevity test to make it easier and faster for a developer to run this test. This test will be run separately from the other NFR tests, due to the fact that it is long-lived. It should not be run in the pipeline. There is still a manual step of collecting dashboard results.

Also separated out functional and nfr tests in the Makefile and README to better separate the two types of tests. These changes force NFR tests to be run in a GKE environment.

Testing: Ran NFR tests and longevity test in a GKE environment and properly collected results.

Closes #1366

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

NONE

@sjberman sjberman requested a review from a team as a code owner March 7, 2024 20:14
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Mar 7, 2024
tests/scripts/create-gke-cluster.sh Outdated Show resolved Hide resolved
tests/scripts/run-tests-gcp-vm.sh Show resolved Hide resolved
tests/suite/longevity_test.go Outdated Show resolved Hide resolved
tests/suite/longevity_test.go Outdated Show resolved Hide resolved
tests/suite/longevity_test.go Outdated Show resolved Hide resolved
tests/Makefile Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Problem: NFR tests are a burden to run manually, taking a lot of time and effort.

Solution: Automate the longevity test to make it easier and faster for a developer to run this test. This test will be run separately from the other NFR tests, due to the fact that it is long-lived. It should not be run in the pipeline. There is still a manual step of collecting dashboard results.

Also separated out functional and nfr tests in the Makefile and README to better separate the two types of tests. These changes force NFR tests to be run in a GKE environment.
@sjberman sjberman enabled auto-merge (squash) March 11, 2024 18:38
@sjberman sjberman disabled auto-merge March 11, 2024 18:44
@sjberman sjberman merged commit 15bab00 into nginxinc:main Mar 11, 2024
36 checks passed
@sjberman sjberman deleted the tests/longevity branch March 11, 2024 18:58
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this pull request Apr 3, 2024
Problem: NFR tests are a burden to run manually, taking a lot of time and effort.

Solution: Automate the longevity test to make it easier and faster for a developer to run this test. This test will be run separately from the other NFR tests, due to the fact that it is long-lived. It should not be run in the pipeline. There is still a manual step of collecting dashboard results.

Also separated out functional and nfr tests in the Makefile and README to better separate the two types of tests. These changes force NFR tests to be run in a GKE environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automate Longevity Test
3 participants