Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic update sensitive to file favicon.ico #578

Open
luenissla opened this issue Aug 22, 2024 · 2 comments
Open

automatic update sensitive to file favicon.ico #578

luenissla opened this issue Aug 22, 2024 · 2 comments
Labels

Comments

@luenissla
Copy link

Nextcloud is a powerful system with many possibilities. Updating from one version to the next also works perfectly automatically.

I noticed that the updater ‘stumbles’ over the small favicon.ico file in the root directory and therefore stops the process.

Nextcloud_Zwischenablage_08-21-2024_01

The favicon.ico file is a small file that most browsers use. As it should have no significance for Nexcloud at this point, its presence should not be a problem and should be ignored.

It would be nice if this could work in one of the following versions.

Translated with DeepL.com (free version)

Regards
Hans-Joachim (Lünenschloß)
https://nextcloud.bvff.de

@joshtrichards
Copy link
Member

Are you placing that file there manually? Because it's likely being ignored. Nextcloud already handles favicon on its own (even when not logged in) via embedding <link rel="icon" href="xxx/favicon/url"> into every page (or the equivalent apple-touch-icon).

@luenissla
Copy link
Author

Are you placing that file there manually?
Hello Josh,
thanks for your response.

Yes, I copied the file manually into the root directory. Nextcloud does it perfectly right with the embedding in the source code.

As far as I know, however, the browsers, at least the Firefox I use, only access a favicon file in the root directory when they show an icon for a tab.
Image

Hence my suggestion that the update routine should accept this small file in the root directory and not abort it.

Regards
Hans-Joachim (Lünenschloß)

@joshtrichards joshtrichards added the hotspot: local changes Temporary to sort these (htaccess, user.ini) label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants