Skip the update if there are incompatible apps (unless forced/overrriden)

[dseomn]

How to use GitHub

• Please use the 👍 reaction to show that you are interested into the same feature.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I have a cron job that includes php7.4 /var/local/nextcloud/webroot/updater/updater.phar --no-interaction --quiet, and the last time it upgraded Nextcloud, it disabled the oidc_login and twofactor_u2f apps, among others. Disabling the former prevents logging in, and unintentionally disabling the latter is a security issue, I think.

Describe the solution you'd like
Add a command-line flag to updater.phar so that if the upgrade would disable any apps, it prints an error message instead of continuing.

Describe alternatives you've considered
A command-line flag that lists specific apps that are considered critical would work too.

Additional context
The issue I had was updating from 22.2.3.0 to 23.0.0.10, and the logs showed these apps disabled:

2021-11-30T23:15:52+00:00 Disabled incompatible app: apporder
2021-11-30T23:15:52+00:00 Disabled incompatible app: metadata
2021-11-30T23:15:52+00:00 Disabled incompatible app: oidc_login
2021-11-30T23:15:52+00:00 Disabled incompatible app: polls
2021-11-30T23:15:52+00:00 Disabled incompatible app: twofactor_u2f

[PrivatePuffin]

Yes, this is really important for the community.
For admins Nextcloud updates are already tricky at times and the "lets just randomly disable stuff", does not make it any beter at all. Even worse: it makes the product borderline unviable, if you use more than just the included Apps.

The same would also be nice for the docker version as well.
By erroring out, it's made clear right away that there are issues with the update, instead of giving a false-positive green-light.

[solracsf]

I agree with this demand, but one note;

• updating ANY software with a Cronjob, without reading a changelog or monitor its behavior, it's a (very) bad practice.

[PrivatePuffin]

I agree with this demand, but one note;

• updating ANY software with a Cronjob, without reading a changelog or monitor its behavior is just a (very) bad practice.

The problem is not nextcloud updates themselves really, the problem is the fact it's made super hard to even know which of your apps are compatible. You would need to view them one-by-one and make lists of the onces that are or are not compatible.

An easy tool to check update compatibility would be a great start to get somewhat ahead of this issue.

[bbx-github]

I would like to have such a feature but because of #241 I doubt it gets implemented.

[joshtrichards]

This would need nextcloud/server#34713.

In theory, we could then integrate this into the Updater as a pre-check step and run it in the same way we do occ upgrade (albeit earlier).