Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to native browser tooltips #4321

Closed
juliusknorr opened this issue Jun 20, 2023 · 0 comments · Fixed by #5174
Closed

Switch to native browser tooltips #4321

juliusknorr opened this issue Jun 20, 2023 · 0 comments · Fixed by #5174
Assignees
Labels

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Jun 20, 2023

As an accessibility requirement we should drop any usage of the custom v-tooltip directive / Tooltip from @nextcloud/vue and use native browser tooltips (with the title attribute instead). Usages should be easy to find:

components/Menu/EmojiPickerAction.vue
27:		<NcButton v-tooltip="actionEntry.label"

components/Editor/GuestNameDialog.vue
24:	<form v-tooltip="t('text', 'Enter your name so other people can see who is editing')" class="guest-name-dialog" @submit.prevent="setGuestName()">
49:		tooltip: Tooltip,

components/Editor/AvatarWrapper.vue
8:			:disable-tooltip="true"

components/Editor/SessionList.vue
26:			v-tooltip.bottom="label"
80:		tooltip: Tooltip,

components/Menu/ActionSingle.vue
101:			tooltip,
107:		// do not use tooltip if is a item of action list
111:				name: 'tooltip',
112:				value: tooltip,

components/Menu/ActionList.vue
24:	<NcActions v-tooltip="tooltip"

components/Editor/Status.vue
25:		<div v-tooltip="lastSavedStatusTooltip" class="save-status" :class="saveStatusClass">

components/Menu/BaseActionEntry.js
68:		tooltip() {

Also fixes #4234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants