Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since NC 25.02 update: publicly shared .md files need additional right for download in order to be displayed. #3704

Closed
ghost opened this issue Jan 27, 2023 · 2 comments · Fixed by #3765
Assignees
Labels
1. to develop bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 27, 2023

Describe the bug
A clear and concise description of what the bug is.

Since NC 25.02 update: publicly shared .md files need additional right for download in order to be displayed.

Before sharing the file with read only worked perfectly! In NC 25.02 and 25.03 (Text App always current: 3.6.0) read only produces bug "file not readable because right to download is blocked". After giving right to download it works. But read only is impossible like that.

To Reproduce
Steps to reproduce the behavior:

  1. Share folder
  2. In sharing options choose "hide download" (as we want read only)
  3. Open shared link in private browser or after being logged out of NC
  4. See error

Expected behavior
.md files should be shared read only.

Screenshots
If applicable, add screenshots to help explain your problem.

Client details:

  • OS: Ubuntu 22.04
  • Browser: tested with firefox 108.0.2, current chromium ....
  • Version: 22.04
  • Device: Laptop
Server details

Text app version: (see Nextcloud apps page)
3.6.0

Operating system:
NC 25.02 and NC 25.03

Web server:
Apache

Database:
MySQL

PHP version:
8.1

Nextcloud version: (see Nextcloud admin page)
NC 25.02 and NC 25.03

Logs

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@ghost ghost added the bug Something isn't working label Jan 27, 2023
@juliusknorr
Copy link
Member

This is actually caused by this line:
https://github.com/nextcloud/text/pull/2776/files#diff-2dc81f0bddfb02f0a6ba96048923dafeb718b07ccd10036e3004dff976411240R499

Hide download is not really well defined in what it should achieve, but I think it makes sense to revert this part of the change to still render hide download share links with text.

@max-nextcloud
Copy link
Collaborator

Removing the good first issue label as there's a pr open now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants