Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of mobile icon overflow #1958

Closed
juliusknorr opened this issue Nov 22, 2021 · 4 comments
Closed

Improve handling of mobile icon overflow #1958

juliusknorr opened this issue Nov 22, 2021 · 4 comments
Labels
bug Something isn't working needs triage: julius

Comments

@juliusknorr
Copy link
Member

As per recent discussion, the current way of overflowing icons has the problem that icons triggering a submenu might then create a two level submenu. Currently this is avoided by just always showing the emoji picker.

@juliusknorr juliusknorr added the bug Something isn't working label Nov 22, 2021
@mejo-
Copy link
Member

mejo- commented Dec 14, 2021

Suggestion from @jancborchardt: The emoji picker could replace the action menu, then it is not as weird.

@juliusknorr
Copy link
Member Author

Not sure I get that fully, the action menu would still be needed for the formatting actions that don't fit the width, or?

@mejo-
Copy link
Member

mejo- commented Dec 15, 2021

Not sure I get that fully, the action menu would still be needed for the formatting actions that don't fit the width, or?

Sure. I think he meant to close the action menu once emoji picker is clicked and only display the emoji picker?

@juliusknorr
Copy link
Member Author

Closing as a duplicate of #2836 which contains more details about the mobile menu bar redesign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage: julius
Projects
None yet
Development

No branches or pull requests

2 participants