App broken on Nextcloud 12.0.x #145
Comments
|
How did you update or install it? I have used and tested it with 12.0.5 and it looks just fine. |
|
Through the web updater. It happened on two different instances, so I guess it wasn't an error while updating. Uninstalling and reinstalling didn't fix it. |
|
This is weird. It looks as if neither CSS nor JS are loaded at all. |
|
Could you check the access rights for the tasks app folder? |
|
They seem to be all right. However, the call to the task app |
|
In 12.0.3, we don't have those SCSS related PRs : nextcloud/server#7688, nextcloud/server#6661, nextcloud/server#7257 |
Hm, can we mitigate this within the app? Or does this mean, we cannot use SCSS in < 12.0.5 at all? Maybe @skjnldsv as well. |
|
Also, could we set 12.0.5 as minimal version? Or we need to ship the compiled css file?? |
|
@raimund-schluessler Nop, scss is active on stable12. Those prs are for a very specific setup when the user has its app directory outside the nextcloud web directory, so maybe it's relevant for you @tcitworld ? IF so, this is not a tasks related issue :) |
|
@skjnldsv my apps directory is under the nextcloud web directory and i have the same issues |
|
Any errors in the nextcloud log? |
|
After manual upgrading from 12.0.0 to 12.0.5 the issues disappeared on chrome. on ie11 it still looks weired |
|
IE is a different problem and not supported. On IE there are more problems than just the styling. Seems like NC12.0.5 is necessary to get rid of SCSS problems. |
|
@raimund-schluessler I'd like to know why though :p |
Yes, that would be good. But I think this is more of a server issue, than an issue of this app. |
|
We need a server log to be sure, but I think too! |
|
Unfortunately I didn't see anything relevant inside it. |
|
@tcitworld did you tried clearing your appdata cache? |
|
Yeah, deleting |
|
Strange. We need to find out what is the issue here. |
|
I vaguely remember that I might have experienced something similar, but I don't know anymore exactly how I solved it. Could you try to create the empty folder |
|
It already had fine access rights. However, it seems the folder isn't repopulated since I deleted files inside it. |
|
I will try with a 12.0.5 installation when I have the time! :) |
|
As @khoebling said it seems to work with 12.0.5, just not with 12.0.3 and 12.0.2. |
|
With 12.0.5 everything worked for me when I tested it. Should we consider this fixed then? |
|
@raimund-schluessler yes, up-to-date versions should be considered as the current supported ones. We need to move forward, we can't patch downward. 👍 |
|
I have no issues with versions not supported being ignored, but it would be better if the app was marked as incompatible with these versions ;) |
|
@tcitworld but 12.0.5 is supported right? :) |
|
Yeah, but we could set |
|
Does the appinfo parser supports it? :p |
|
I just went through the logs again, but there were no errors before updating to 12.0.5 |
If the parser supports that, we will change it accordingly. |
|
I think I found the issue : Line : https://github.com/nextcloud/tasks/blob/master/css/src/nc12.scss#L242 |
Could be, it was added from 12.0.3 (https://github.com/nextcloud/server/blob/v12.0.3/core/css/variables.scss) to 12.0.4 (https://github.com/nextcloud/server/blob/v12.0.4/core/css/variables.scss). Does it work when you add it? We could easily add it to the NC12 scss code then. |
|
I tried, unfortunately deleting the files inside appdata_/css/tasks/ and force refreshing or running cron doesn't seem to recreate them. Anyway to clear the SCSS cache properly ? |
|
@tcitworld see rullzer's app for this purpose https://github.com/rullzer/appdatacleaner |
|
Yup, fixes it. 👍 |
|
Ok, then I will add this variable to https://github.com/nextcloud/tasks/blob/master/css/src/nc12.scss |
|
Fix is in #147 |
|
Problem should be fixed now. Would you consider this worth a new release? |
|
Well, no one else reported the issue here or on https://help.nextcloud.com so I guess it's fine to wait next release. |
|
Just updated tasks (0.9.6) on my NC12 (<12.0.5) and got the same issue. |
|
I'm using Nextcloud 12.0.3 and installed tasks 0.9.6 from the admin UI. I also experienced this issue. I will try updating to Nextcloud 13 later. |
|
Ohh, I get it, the fix isn't in the latest release. Yes, if you made a new release that would be helpful! Thank you. |
|
Upgrading to 12.0.5 or the latest is far easier ;) |
|
I've upgraded to 12.0.5 but still having the issue. I chose not to go with 3.0 because I'm using mailinabox which doesn't support it yet. |
|
I'm also happy manually editing the .scss file to make this change, but I'm not sure how to use the above-linked appdatacleaner 😕 |
|
I ended up resolving this temporarily by editing |
|
@raimund-schluessler Sad to report it's again broken with 0.97 and NC 13.0.5. |
@tcitworld Could you elaborate a bit on that, please? I don't know, what should have caused that. There were no changes on the scss files which I could imagine doing so: v0.9.6...v0.9.7 |
Steps to reproduce
Expected behaviour
Good display
Actual behaviour
Display is broken. Browser and server logs don't seem to contain any relevant info, it's just the CSS/JS that's broken.
P.S : Integrity check failure isn't related to this app.
Server configuration
Operating system: Debian
Web server: Nginx
Database: MySQL
PHP version: 7.0
Nextcloud version: (see Nextcloud admin page)12.0.2 (same with 12.0.3)
Tasks version: (see Nextcloud apps page) 0.9.6
Client configuration
Browser: Firefox Nightly, Chromium stable
Operating system: Debian unstable
The text was updated successfully, but these errors were encountered: