Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to delete chat messages #774

Closed
mathiasconradt opened this issue Apr 13, 2018 · 25 comments · Fixed by #4861
Closed

Allow to delete chat messages #774

mathiasconradt opened this issue Apr 13, 2018 · 25 comments · Fixed by #4861

Comments

@mathiasconradt
Copy link

mathiasconradt commented Apr 13, 2018

Enhancement / feature request:

Moderator as well as user who wrote a message should be able to remove a chat message again.
Use case: somebody copy/pasted a password into the chat by accident. Legally problematic text, bad language, etc.

Should be handled in similar way as with any other messenger.

As discussed with Joas: might make sense to instead of completing deleting the line, replace it with a placeholder (i.e. some gray bar or similar) so people know that a message/line has been removed, so that other messages around that still make sense in the context.

UI-wise: a trashcan icon on the right side that appears when the user hovers over a chat line.

@nickvergessen nickvergessen added this to the 4.0 (Nextcloud 14) milestone Apr 20, 2018
@nickvergessen nickvergessen added the feature: chat 💬 Chat and system messages label Apr 23, 2018
@diplodata
Copy link

Would it be possible to have an update on this issue? Lack of ability to delete a message is a real problem for my users, and goes against (most) social media conventions.

@nickvergessen
Copy link
Member

Not really planned atm, since well its a chat. What you sent can be read already

@diplodata
Copy link

diplodata commented Jul 31, 2018

OK. Well it's your app. But I'd say that "might be already read" is badly flawed logic. @mathiasconradt makes the good point about what if you accidentally paste/post something you'd never wish to share (like a password) or even detail that you really should not share for other reasons (perhaps ethical or legal). In that case you'd be able to remove it immediately, before broad consumption and quite possibly before anyone has read it.

IMO this app is an important tool for enabling Nextcloud to seriously challenge Slack. Enabling this functionality would be a small but important way of strengthening that challenge.

@ghost
Copy link

ghost commented Sep 25, 2018

Deleting messages in chats isn't really unheard of. Afaik you can edit/delete messages in Slack if the admin allows it and several messaging apps even offer ephemeral messages that auto-delete themselves after a set time.
A delete function might also be used as a base for other features like a message archive management, to store only the last xyz messages or x months/years of messages.

@nickvergessen nickvergessen modified the milestones: 5.0.0, 💚 Next Major Dec 7, 2018
@radoeka
Copy link

radoeka commented Jan 26, 2019

Just tried to delete a message in a chat at talk version 5.0.2, but that is not possible.
Owncloud is to give users control over their data, however in this case I can't delete messages from chat. That really surprises me.

Is possible to indicate when it will be possible to remove messages from the chat?

@jospoortvliet
Copy link
Member

@radoeka this is planned for the next release, actually, we can't finish everything at once 🚀

But note that the guarantee of data control Nextcloud offers is by self-hosting. Reality is that another user can always take a picture of the message or copy it - this is the internet, once something is sent out you can't take it back. You can try, but it is like MS Outlook's ability to recall emails - yeah, fun, but it won't work with my mail client and you can't erase somebody's memory or screenshots or copies they made...

@Elfanar
Copy link

Elfanar commented Feb 20, 2019

I would really love to see this working.

@goekce
Copy link

goekce commented Jun 21, 2019

Feature would also be useful for chats with a very long history. In my particular case opening a chat with a frequent chat partner takes about five seconds until Nextcloud Talk skipped to the most recent message.

@nickvergessen
Copy link
Member

yeah, but that will be fixed with #1164
It shouldn't require you to delete all the history everytime.

@goekce
Copy link

goekce commented Jun 21, 2019

you are right, #1164 would definitely be the solution. Deletion feature would be just a workaround.

@born2webdesign
Copy link

@jospoortvliet Glad to hear about that ‘next release’ :) But—when will that come? ;) I get it that priorities may shift, but to me this is a real show-stopper. Is this still scheduled? Looking forward to it!
@nickvergessen, @goekce Right, the solution—just not for the problem originally asked about here ;)

@nickvergessen
Copy link
Member

It's currently not planned for one of the next releases due to priorities, but it was moved to backlog. Let me quote the readme:

You can always pick a task of any of the milestones and we will help you to get it into the assigned milestone or also an earlier one if time permits. It's just a matter of having an overview and better visibility what we think should be worked on, but it's not exclusive.

@Eisteed
Copy link

Eisteed commented Mar 6, 2020

Is there any eta on delete / edit message ? Kind of a must have feature for a chat application :/ ..

@nickvergessen
Copy link
Member

See the message above yours

@Eisteed
Copy link

Eisteed commented Mar 6, 2020

Thank you I can read answer from 15 Jul 2019, I just wanted to know if there was anything new on this today, I guess the answer is still no then.

@FlyGitJet
Copy link

FlyGitJet commented May 7, 2020

Hi. First of all, awesome App! But i would agree, deleting or editing messages would be more than great. I am using nextcloud Talk for a primary school right now, and we have several critical usecases for this Feature:

  • Teacher is monitoring the discussion and needs to deleted wrong or inappropriate Message as moderator. He actually HAS to be able to do this!
  • Parents want to remove a Message their Child has written
  • Kids tent to send wrong Messages and want to correct them. Worst Case they will be laugh at due to a bad / wrong Message and they can't delete it

I agree, deleting does not solve the issue of someone doing local copies. But this is far less a danger then the usescases above. So currently we would love to give the Kids our own, secured Messenger, but this Feature might become a Road Blocker for us, for teachers even aus a legal aspect, despite that Talk is such a great App that really would Help our school right now.

Btw: both is possible in this chat here and i just used it :-)

@Nyco
Copy link
Contributor

Nyco commented May 12, 2020

Note : Edit chat messages #1836

@HammyHavoc
Copy link

Just showing my support for implementing this. Not allowing deletion of messages in 2020 really holds Talk back from being a serious contender for us.

@kesselb
Copy link
Contributor

kesselb commented Oct 21, 2020

@HammyHavoc use https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ to show your support. Writing a comment sends a notification to everyone subscribed to this issue.

@Terrox
Copy link

Terrox commented Oct 23, 2020

But note that the guarantee of data control Nextcloud offers is by self-hosting. Reality is that another user can always take a picture of the message or copy it - this is the internet, once something is sent out you can't take it back.

That isn't the point and I don't see why it is a reason to avoid consideration of message deletion (I've seen this on the same topic in Roll20). Just because someone might have a copy of some data doesn't mean there's no point removing it. Chat would be MUCH more useful if the admin could remove messy and wrong messages for things like Project discussions, Play-By-Post games, seminar chats and so on. The messages can be deleted in the database manually anyaway, so there is no way that anyone thinks it is a perfectly trustworthy permanent record.

@HammyHavoc
Copy link

But note that the guarantee of data control Nextcloud offers is by self-hosting. Reality is that another user can always take a picture of the message or copy it - this is the internet, once something is sent out you can't take it back.

That isn't the point and I don't see why it is a reason to avoid consideration of message deletion (I've seen this on the same topic in Roll20). Just because someone might have a copy of some data doesn't mean there's no point removing it. Chat would be MUCH more useful if the admin could remove messy and wrong messages for things like Project discussions, Play-By-Post games, seminar chats and so on. The messages can be deleted in the database manually anyaway, so there is no way that anyone thinks it is a perfectly trustworthy permanent record.

Consider this: Windows now includes a clipboard with history, I accidentally sent the wrong screenshot to a colleague and was unable to remove it. Imagine if I'd sent a screenshot or a piece of text with sensitive information in it. A user-facing method to delete messages is a complete no-brainer to include.

And regarding it "being the internet", not necessarily, it's quite commonly just the corporate intranet. Obviously the thing to do is to minimize the number of people that the data reaches. Imagine making an error of these proportions in a group chat of several dozen people.

@Terrox
Copy link

Terrox commented Oct 23, 2020

As another point - I would prefer both edit & delete, but anything is better than nothing as is. The Chat messages are stored in the Comments table, same table as File Comments - File Comments has edit and delete already. So there is at least some reference code to work from.

@Terrox
Copy link

Terrox commented Oct 23, 2020

is to minimize the number of people that the data reaches. Imagine making an error of these proportions in a group chat of several dozen people.

Well that would actually require live editing connected participants chat windows, some of us are not concerned with that part yet - we just want the record edited regardless of what anyone's screen currently shows. Syncing the chat log would be fine I imagine though, after edit/delete the server sends resync command to all users - text changes.

@HammyHavoc
Copy link

is to minimize the number of people that the data reaches. Imagine making an error of these proportions in a group chat of several dozen people.

Well that would actually require live editing connected participants chat windows, some of us are not concerned with that part yet - we just want the record edited regardless of what anyone's screen currently shows. Syncing the chat log would be fine I imagine though, after edit/delete the server sends resync command to all users - text changes.

As long as there's a user-facing option in the web and app UI for removing a message, I think it's a very important step forward for making Nextcloud Talk a serious option.

@nickvergessen
Copy link
Member

nickvergessen commented Oct 23, 2020

It's not easy like with file comments, as chat messages can be federated with the matterbridge and the mobile clients fetch them once and store them locally, so that needs a separate way to update them there.

I'm locking this for now as no comments are necessary at this point.
We know the reasons for the feature (that's why it's still open).
We will fix it at some point when it reached the top of the todo list.
Until then anyone can pick it up and send a pull request to fix it.

@nextcloud nextcloud locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.