Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar link is a link without href, should be button since it is a modal dialog #7522

Closed
Tracked by #6801
AndyScherzinger opened this issue Jul 6, 2022 · 1 comment · Fixed by #7618
Closed
Tracked by #6801

Comments

@AndyScherzinger
Copy link
Member

No description provided.

@marcoambrosini
Copy link
Member

So I've looked a little bit into this, and this shouldn't be a button because of the elements it contains (div and p). A button can only contain phrasing content.

From what I understand the an a element without href attribute is legal, but aria-wise the role is not link anymore, therefore it needs to be specified. I propose we keep the a and adding role="button"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants