Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations overflow the menu #4993

Closed
nickvergessen opened this issue Jan 21, 2021 · 7 comments
Closed

Translations overflow the menu #4993

nickvergessen opened this issue Jan 21, 2021 · 7 comments

Comments

@nickvergessen
Copy link
Member

Steps to reproduce

  1. Select german language
  2. Try to access conversation settings

Expected behaviour

Actual behaviour

Bildschirmfoto von 2021-01-21 15-51-16

@PVince81
Copy link
Member

Need to use longtext instead of text to wrapping. But in this one case which is not wrappable, might need to adjust the longtext handling of the action menu items to allso ellipsize...
Or change the translation to at least contain some spaces. (too bad that there is no tech standard for wrapping German words at the correct position)

@PVince81 PVince81 self-assigned this Jan 22, 2021
@nickvergessen
Copy link
Member Author

Or we bump the default width by ... 25-50%?

@PVince81
Copy link
Member

default with is 185px in hard-coded in nextcloud-vue.
we could either increase it there or add an override in Talk specifically for this one menu

@PVince81
Copy link
Member

hah... the french translation is longer but thanks to the spaces it wraps:
image

I've checked all translations and there's only German and another one Konversationsinställningar which are without spaces.

So let's increase it to 220px.

@PVince81
Copy link
Member

PVince81 commented Jan 22, 2021

@PVince81
Copy link
Member

PR here: #5000

@PVince81
Copy link
Member

Fixed by dep update: #5001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants