diff --git a/apps/provisioning_api/lib/Controller/UsersController.php b/apps/provisioning_api/lib/Controller/UsersController.php index 25cc13d1c32a2..e165457a339d8 100644 --- a/apps/provisioning_api/lib/Controller/UsersController.php +++ b/apps/provisioning_api/lib/Controller/UsersController.php @@ -604,7 +604,7 @@ public function addToGroup($userId, $groupid = '') { public function removeFromGroup($userId, $groupid) { $loggedInUser = $this->userSession->getUser(); - if($groupid === null) { + if($groupid === null || trim($groupid) === '') { throw new OCSException('', 101); } diff --git a/apps/provisioning_api/tests/Controller/UsersControllerTest.php b/apps/provisioning_api/tests/Controller/UsersControllerTest.php index c712cd7485dd4..2b431d0e71626 100644 --- a/apps/provisioning_api/tests/Controller/UsersControllerTest.php +++ b/apps/provisioning_api/tests/Controller/UsersControllerTest.php @@ -2117,6 +2117,20 @@ public function testRemoveFromGroupWithNoTargetGroup() { $this->api->removeFromGroup('TargetUser', null); } + /** + * @expectedException \OCP\AppFramework\OCS\OCSException + * @expectedExceptionCode 101 + */ + public function testRemoveFromGroupWithEmptyTargetGroup() { + $loggedInUser = $this->getMockBuilder('\OCP\IUser')->disableOriginalConstructor()->getMock(); + $this->userSession + ->expects($this->once()) + ->method('getUser') + ->will($this->returnValue($loggedInUser)); + + $this->api->removeFromGroup('TargetUser', ''); + } + /** * @expectedException \OCP\AppFramework\OCS\OCSException * @expectedExceptionCode 102