-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App management navigation has padding on bottom #9974
Comments
This should be automated with css. I guess we need to also update the positioning of the settings? |
GitMate.io thinks possibly related issues are #2189 (App-navigation without settings should not have padding-bottom), #2612 (Non interactive app navigation entry), #3346 (Left shadow in app-navigation missing from user settings), #4629 (App navigation styles: entries in folders not highlighted correctly, incorrect padding for entries with counters), and #5960 (App management: Apps not properly sorted by A-Z). |
Yep, as said I thought I remember this worked before. But then again, how can you modify a parent’s style based on if they have a child or not. We could require a class like
What do you mean by that? There’s no settings here at all, so nothing to update? |
No, we need to stop using classes as toggles! :) |
Haha – nevermind, we do already have this class and use it in personal settings ;) it’s
Currently you can not modify a parent based on a child using CSS. :) See caniuse :has() CSS relational pseudo-class |
Ok, this apparently has to be done by someone who knows Vue, as I have no idea where to insert the class or the logic for it. Seems either settings/src/components/appNavigation.vue or settings/src/views/Apps.vue |
There are other ways to do that than use a padding on the parent |
I know, we can use fancy ways for lots of things – but I can't see how to use them short of rewriting our HTML. Which is not a proper fix in this case where we simply need to add a class we already use. So if there are other ways we can do this for Nc 14, let me know. :) Otherwise, @juliushaertl @skjnldsv can you educate me where/how I would have to add the class in the Vue template? |
Here you go @jancborchardt #9977 :) Nonetheless if you want to still improve your vue knowledge, I'd be happy to help ;) |
There is no settings area for settings, so we don’t need the padding on the bottom:
@nextcloud/designers didn’t we have that in the CSS before?
The text was updated successfully, but these errors were encountered: