'Name' from Theming should not be used in 'Version' in the admin settings

[nursoda]

Steps to reproduce

1. Set a 'Name' in Theming, e.g. NAME
2. Open https://seyfarth.de/cloud/index.php/settings/admin

Expected behaviour

Version should read "Nextcloud VERSION"

Actual behaviour

Version reads "NAME VERSION"

Note that this also baffled the author of the talk app since he used it (until a couple of days ago) to identify that the server is a nextcloud instance. 'Name' should be a display-only value, not to identify the product. The product neets a separate variable / identifier (and probably has). This should be used to display the "Product + Version" here, too.

[MorrisJobke]

That's not really a regression, because we did this in the past always like that.

https://github.com/nextcloud/server/blob/master/settings/templates/settings/admin/server.php#L226

@karlitschek What is your opinion here? I would be fine to hardcode "Nextcloud" there, because it is also only visible on the admin settings anyways.

cc @rullzer @blizzz

[rullzer]

The thing @mario ran into was in the status.php I bet. So it is not exactly the same issue.

I don't have a strong preference here. But I guess some buisnesses want the branded name in status.php.

[mario]

Yes, I used productname in status.php to identify the instance as Nextcloud. I have since removed the check since it's easily change-able anyway :)

[karlitschek]

There are scenarios it should be possible to hide 'Nextcloud' completely. Even for the Admin. This is mainly for 'real' themes of course. So not sure we should change the current behaviour.

[nursoda]

I'm fine with "MyName Version", but maybe you should just omit NAME in settings/general in the "Version" section?

[blizzz]

I think we leave it as it is, since it does not really fix a real issue, right?

Let me close it since it is stale for awhile. We can still reopen if it is a real problem.