-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small adjustments needed to the login screen #7265
Labels
1. to develop
Accepted and waiting to be taken care of
design
Design, UI, UX, etc.
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
low
papercut
Annoying recurring issue with possibly simple fix.
Comments
pixelipo
added
1. to develop
Accepted and waiting to be taken care of
design
Design, UI, UX, etc.
low
papercut
Annoying recurring issue with possibly simple fix.
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
labels
Nov 23, 2017
@pixelipo Is this still available? If so I can take it? |
Yes it is, @rpirritano - be my guest :) |
Ot should definitely appear under all the buttons. Ideally, it should also disappear as soon as "Forgot password?" button is clicked. That way, only one error should be visible at any given moment. |
I completed all the above changes, submitted the pull request. |
Fixed with #7650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1. to develop
Accepted and waiting to be taken care of
design
Design, UI, UX, etc.
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
low
papercut
Annoying recurring issue with possibly simple fix.
Copied from #7249 (comment)
OK, here's my
reviewopinion. I'm adding it as a comment since it's not breaking issues, but I would like to see these fixed:Logo is too high up; actually, its distance from top is OK, but now it's too far from the
form
itself:I would remove 16px top+bottom margins from
form {}
in guest.css since they don't seem neededIs there a reason why
footer
hasheight: 70px
? We can easily remove it (I think) and change thep.info {margin: 0 auto; padding-top: 20px;
to simplerp.info {margin: 20px auto;}
Added advantage to these changes would mean that the whole page would fit nicely on 320*480 screen:"Wrong password " warning is above the
#submit# button, but the
#lost-password` warning is bellow - makes no sense at all:Additionally, "Lost Password" warning also has
opacity: .7;
added to it for some reason.The text was updated successfully, but these errors were encountered: