Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small adjustments needed to the login screen #7265

Closed
pixelipo opened this issue Nov 23, 2017 · 6 comments
Closed

Small adjustments needed to the login screen #7265

pixelipo opened this issue Nov 23, 2017 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. low papercut Annoying recurring issue with possibly simple fix.

Comments

@pixelipo
Copy link
Contributor

Copied from #7249 (comment)

OK, here's my review opinion. I'm adding it as a comment since it's not breaking issues, but I would like to see these fixed:

  1. Logo is too high up; actually, its distance from top is OK, but now it's too far from the form itself:
    image
    I would remove 16px top+bottom margins from form {} in guest.css since they don't seem needed

  2. Is there a reason why footer has height: 70px? We can easily remove it (I think) and change the p.info {margin: 0 auto; padding-top: 20px; to simpler p.info {margin: 20px auto;} Added advantage to these changes would mean that the whole page would fit nicely on 320*480 screen:
    image

  3. "Wrong password " warning is above the #submit# button, but the #lost-password` warning is bellow - makes no sense at all:
    image

  4. Additionally, "Lost Password" warning also has opacity: .7; added to it for some reason.

@pixelipo pixelipo added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. low papercut Annoying recurring issue with possibly simple fix. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Nov 23, 2017
@rpirritano
Copy link
Contributor

@pixelipo Is this still available? If so I can take it?

@pixelipo
Copy link
Contributor Author

Yes it is, @rpirritano - be my guest :)

@rpirritano
Copy link
Contributor

@pixelipo ,
For item #3 above, do you want the Wrong Password warning to no longer appear on that page or do you just want it to remain, but right above lost-password warning?

@pixelipo
Copy link
Contributor Author

Ot should definitely appear under all the buttons. Ideally, it should also disappear as soon as "Forgot password?" button is clicked. That way, only one error should be visible at any given moment.

@rpirritano
Copy link
Contributor

I completed all the above changes, submitted the pull request.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@juliusknorr
Copy link
Member

Fixed with #7650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. low papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

6 participants