-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Disabling the preview does not stop the creation of the folder tree #45697
Comments
True. With enabled_previews = false, no preview providers are registered and therefore not previews are generated. But currently some code before, like requesting a generator instance, creating the folder structure, BeforePreviewFetchedEvent still runs. The patch below should improve it.
|
@kesselb I like it. I also tested it locally and it works fine. Do you mind opening a PR? |
I applied the patch to 29.0.1, and it works beautifully. We were hit by this in our use case : Thanks ! |
same problem here. Is there a fix coming for normal patching? (stable) |
@kesselb would you mind creating a PR from your patch? |
Bug description
I am encountering an issue: my NextCloud instance is installed on an ext4 partition with limited inode resources. The preview feature generates a very large number of folders that consume all available inodes and block the entire system. Despite disabling the preview feature in the configuration file, this folder tree continues to be created empty. Could you please fix the problem quickly?
For more information:
https://help.nextcloud.com/t/the-preview-feature-consumes-too-many-inodes/194129
Steps to reproduce
sudo -u www-data php /var/www/nextcloud/occ files:scan-app-data
df -i /dev/sda1
systemctl stop apache2
rm -rf /var/www/nextcloud/data/appdata_xxx/preview/*
sudo -u www-data php /var/www/nextcloud/occ files:scan-app-data
df -i /dev/sda1
systemctl start apache2
Expected behavior
Disabling the preview feature stops the creation of all files and folders, not just files.
Installation method
None
Nextcloud Server version
29
Operating system
Debian/Ubuntu
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
No response
List of activated Apps
No response
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: