Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Create possibility to change a color theme for native datetime picker on dark theme #42392

Closed
JuliaKirschenheuter opened this issue Dec 20, 2023 · 6 comments · Fixed by nextcloud-libraries/nextcloud-vue#4981 or nextcloud-libraries/nextcloud-vue#5182
Closed

[BITV]: Create possibility to change a color theme for native datetime picker on dark theme #42392

JuliaKirschenheuter opened this issue Dec 20, 2023 · 6 comments · Fixed by nextcloud-libraries/nextcloud-vue#4981 or nextcloud-libraries/nextcloud-vue#5182
Assignees
@JuliaKirschenheuter
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

For now a picker itself is not visible on dark theme. This have to be changed.

Screenshot from 2023-12-20 10-58-33

Have to be changed to:

Screenshot from 2023-12-20 11-00-10
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Dec 20, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 20, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Dec 20, 2023
Merged
2 tasks
@szaimen
Copy link
Contributor

szaimen commented Jan 4, 2024

I checked on 28 and it doesnt seem to be working yet:
image
(also the icon is not visible)

@szaimen szaimen reopened this Jan 4, 2024
@szaimen
Copy link
Contributor

szaimen commented Jan 4, 2024

The problem seems to be that I am using system default theme:
image

@JuliaKirschenheuter
Copy link
Contributor Author

image

@JuliaKirschenheuter JuliaKirschenheuter mentioned this issue Jan 30, 2024
Merged
3 tasks
@emoral435
Copy link
Contributor

Moved to Parked, as we will need to wait to get stable28's library bumped :)

@szaimen szaimen reopened this Feb 8, 2024
@szaimen
Copy link
Contributor

szaimen commented Feb 9, 2024

Still doesnt seem to work with follow system theme on stable 28 😢
image

@JuliaKirschenheuter
Copy link
Contributor Author

can be closed when #43485 is merged

@szaimen szaimen closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
Milestone
No milestone
3 participants
@JuliaKirschenheuter @szaimen @emoral435