-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Guard-App capabilities into core #40659
Comments
We will probably need some estimate about the time needed to re-implement these features in core and see if/how much of the code we can "copy paste". A preliminary scan of the available checks&benchmarks are:
|
Is this supposed to replace current «Security & setup warnings» section? Regarding Nextcloud guard, it’s doing benchmarks, do we really want to execute benchmarks at each administration settings load? Seems like a bad idea as people will open admin settings when things are going wrong and it might not be the right time to put pressure on the system. Quick review of guard checks:
Guard benchmarks:
|
^ cc @jancborchardt |
I agree that we shouldn't be running the benchmarks every time every time the admin overview is loaded. |
What we could do is show (possibly behind a button click) the checks which are passing, so that admins can see what the setup checks are checking. |
Can someone post a Guard screenshot? @come-nc thanks for the summary, maybe what we could do is show the last results in a greyed out way and offer a button to re-trigger the scan? And yes I would say it should be part of the admin overview. If you think it is too unrelated to the "Security & setup checks" section then it can be its own below. |
Subtask to #40160
The goal is to merge the code from the Nextcloud Guard app into core and use its capabilities from there. The infos and checks that are provided via guard should be displayed in the Admin overview, for the ones possible.
The text was updated successfully, but these errors were encountered: