Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming refactoring follow-ups #35479

Closed
szaimen opened this issue Nov 29, 2022 · 2 comments · Fixed by #36931
Closed

Theming refactoring follow-ups #35479

szaimen opened this issue Nov 29, 2022 · 2 comments · Fixed by #36931
Assignees
@skjnldsv
Labels
3. to review Waiting for reviews 26-feedback bug feature: theming
Milestone
Nextcloud 26

Comments

@szaimen
Copy link
Contributor

szaimen commented Nov 29, 2022 •
edited by skjnldsv
Loading

  • should the Change color option really be part of the background grid? In my opinion it should be rather outisde as it is not a background option...
  • Remove background should be shown as selected if it is selected imho and it should have the background color that is currently active, imho.
    image
@szaimen szaimen added bug 1. to develop Accepted and waiting to be taken care of feature: theming labels Nov 29, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Nov 29, 2022
@szaimen

This comment was marked as resolved.

Sign in to view
@HannesJo0139

This comment was marked as off-topic.

Sign in to view
@skjnldsv skjnldsv mentioned this issue Mar 1, 2023
Merged
@skjnldsv skjnldsv self-assigned this Mar 1, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews 26-feedback bug feature: theming
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging a pull request may close this issue.

fix(theming): select "no-background" option and fix layout order nextcloud/server
3 participants
@skjnldsv @HannesJo0139 @szaimen