Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with horizontal resize and sidebar responsiveness in files app (Chromium 104) #33808

Closed
1 task
juliusknorr opened this issue Sep 1, 2022 · 5 comments
Closed
1 task

Comments

@juliusknorr
Copy link
Member

  • BUG: issue with horizontal resize and sidebar responsiveness in files app (Chromium 104)

resize-sidebar-issue

Steps to reproduce:

  1. Reduce width until the left sidebar disappears
  2. Click the hamburger menu to make it appear
  3. Resize horizontally while the sidebar is still open
  4. Be unlucky 🍀

Expected

No sizing issue

Actual

If you're lucky, the content width animates back to the correct position.
If unlucky, the animation gets stuck/reset and the content does not readjust.

Maybe related to the snap.js library which is known to have race condition issues.
=> If not easy to reproduce (I tend to be unlucky), let's skip this

Originally posted by @PVince81 in #33568 (comment)

@jancborchardt
Copy link
Member

Maybe related to the snap.js library which is known to have race condition issues.

I was thinking that as well. To be quite honest, we can also get rid of this library if it causes so many issues.

@szaimen
Copy link
Contributor

szaimen commented Sep 5, 2022

+1 getting rid of the library

@szaimen
Copy link
Contributor

szaimen commented Sep 5, 2022

cc @nextcloud/server-frontend

@skjnldsv
Copy link
Member

skjnldsv commented Sep 6, 2022

This happens in other areas too, it's not just that library.

@skjnldsv
Copy link
Member

Cannot reproduce anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants