Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings panel in sidebar, separation a bit too weak visually #33802

Closed
juliusknorr opened this issue Sep 1, 2022 · 2 comments · Fixed by #33900
Closed

Settings panel in sidebar, separation a bit too weak visually #33802

juliusknorr opened this issue Sep 1, 2022 · 2 comments · Fixed by #33900

Comments

@juliusknorr
Copy link
Member

BUG: design: settings panel in sidebar, separation a bit too weak visually

image

@jancborchardt
Copy link
Member

So @juliushaertl and I looked at this, and we wanted to add some additional whitespace on top if the menu is open (it should not be there when closed as otherwise the distance to the entries above will be too much.

Unfortunately, the .open/.opened class is applied only to the settings content, not to the whole container, so we can not add extra padding based on that. It could be fixed by applying the .open/.opened class to the settings container which includes both the settings header/button and the settings content.

@szaimen szaimen added the 2. developing Work in progress label Sep 5, 2022
@szaimen
Copy link
Contributor

szaimen commented Sep 5, 2022

Done with #33900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants