-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRUD permissions for internal & external shares #30227
Comments
Though if upload+editing at the same time is used often which I suppose it would be (at least for private users), I think it shouuld be one of the default options as well... |
Could be – but do we have a reason to think that this is very common? Others definitely don’t offer it in their sets of standard options instead focusing on "View" and "Edit". |
I'd say sharing your own pictures after an event with friends with a link and allowing them to upload files at the same time is a very common usecase but yeah... Just wanted to bring this into focus ;) |
While working on the permissions and harmonize the permissions for internal and external shares it would be nice to add following permissions for internal share:
This permissions are often requested for Virtual Data Room scenarios. Question is how to handle this permissions in the clients, my idea:
|
This would change the scope and if not needed for this one I'd like them to be a separate issue because it doesn't just change the scope it also leads to new open issues that potentially slow down the implementation since they now also impact clients and a read-only file I think should still be "one way synced" server-to-client but any local change would have to be overwritten or create a warning or an error or else. So let's not add further aspects to the issue please. |
As also communicated with @artonge, for the record here: The mockup for the extended permissions is based on the new sharing design #26691 If that is not ready, this is how the extended permissions could look like in the current view
|
Is Delete permission working ? #33917 |
How to use GitHub
Is your feature request related to a problem? Please describe.
For external shares we only have “read only” and “allow upload and editing”.
Describe the solution you'd like
We would need to extend the permissions to have "read", “create”, “edit”, “delete”. In the past we went in the other direction, making share permissions less complex. So now we would revert it and add the complexity again (maybe as a config option so that admins can chose between simple and advanced share permissions?)
Describe alternatives you've considered
None
The text was updated successfully, but these errors were encountered: