Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login with device page is not properly styled #27530

Closed
MorrisJobke opened this issue Jun 16, 2021 · 3 comments · Fixed by #27566
Closed

Login with device page is not properly styled #27530

MorrisJobke opened this issue Jun 16, 2021 · 3 comments · Fixed by #27566
Assignees
@Pytal
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 22

Comments

@MorrisJobke
Copy link
Member

  • click on the "Login with device" link on the login page
  • expect properly designed and styled page - white text, proper border radius for inputs, darker background for errors, error with icon
  • actual:
    Bildschirmfoto 2021-06-16 um 16 18 13
    Bildschirmfoto 2021-06-16 um 16 23 46

Expected design:

Bildschirmfoto 2021-06-16 um 16 25 27
Bildschirmfoto 2021-06-16 um 16 25 38

cc @nextcloud/designers
@MorrisJobke MorrisJobke added bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. labels Jun 16, 2021
@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone Jun 16, 2021
@Pytal
Copy link
Member

Pytal commented Jun 17, 2021

I'll take this, @nextcloud/designers design suggestions?

@skjnldsv
Copy link
Member

For me it is styled 🤔
Peek 17-06-2021 07-53

@MorrisJobke
Copy link
Member Author

For me it is styled 🤔

The border radius of the input field is not correct. Enter also a wrong user name and try to login. Then an error is shown.

@Pytal Pytal mentioned this issue Jun 18, 2021
Merged
@Pytal Pytal added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jun 18, 2021
@Pytal Pytal self-assigned this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging a pull request may close this issue.

Update Login with device page styles nextcloud/server
3 participants
@MorrisJobke @skjnldsv @Pytal