-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept shares, show pending shares on top of view #2192
Comments
Sounds good to me |
We would like that too! |
@schiessle @jancborchardt @karlitschek We should have this in our list for 13. |
agreed! |
A higher priority is the general shares overview page: #5559 There we can simply show the pending shares up top, without the need for yet another sidebar entry. |
Hi, IMHO that function is not only a enhancement, but it's also a security issue because without this feature (current behaviour) if someone share something to me, desktop client will download that file without my approvation, and IMHO it's a potential way for malware propagation. Is it wrong? |
@GioInside only if it is from a user on your server. Not if it is a remote share, those you have to accept first, so I think this is, security-wise, done right already. |
Let's move it to 17. |
So…how we gonna do this? (calling this all the time is, at least on Mobile, not a good solution, as we already have too many calls). |
Also ref #27704 |
The pending shares should show on top of the files view, without the need for yet another sidebar entry.
Incoming should be at the top, and rejected ones sorted at the bottom and greyed out. That way you can also get rejected shares back.
For incoming shares you can accept or reject them, and for rejected shares you can re-accept (undo rejection) or permanently delete. (Otherwise you’re stuck with a »pending shares« section for longer than you want.)
cc @nickvergessen @schiessle
The text was updated successfully, but these errors were encountered: