Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinIO S3 Patch Issue #17394

Closed
nagdevAmruthnath opened this issue Oct 3, 2019 · 3 comments
Closed

MinIO S3 Patch Issue #17394

nagdevAmruthnath opened this issue Oct 3, 2019 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@nagdevAmruthnath
Copy link

nagdevAmruthnath commented Oct 3, 2019

Background

There was MinIO directory sync issue and a patch was provided to solve it.

Problem

The following #9808 (comment) gives error. There seems to be an issue with the patch or consecutive commits.
error: unrecognized input

Reproducable

>root@nextcloud:/var/www/html# curl -L  https://github.com/nextcloud/server/compare/bugfix/6954/scan-external-s3.patch -o /tmp/scan-external-s3.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  273k    0  273k    0     0   507k      0 --:--:-- --:--:-- --:--:--  507k

>root@nextcloud:/var/www/html# git apply /tmp/scan-external-s3.patch 
error: unrecognized input

Environment

Running this as docker container pulled from image nextcloud:17.0.0RC2

@nagdevAmruthnath nagdevAmruthnath added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 3, 2019
@kesselb
Copy link
Contributor

kesselb commented Oct 3, 2019

The branch does not exist anymore. You can grab the patch from: #14913 (patch file)

@kesselb kesselb closed this as completed Oct 3, 2019
@nagdevAmruthnath
Copy link
Author

The branch does not exist anymore. You can grab the patch from: #14913

I used the patch from there and it did not work.

root@test# curl -O https://github.com/nextcloud/server/compare/bugfix/14913/scan-external-s3.patch | git apply -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  273k    0  273k    0     0   467k      0 --:--:-- --:--:-- --:--:--  466k
error: unrecognized input
root@test#

@kesselb
Copy link
Contributor

kesselb commented Oct 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

2 participants