Update notification shows warning for non-app store app

[MorrisJobke]

• having an app installed, that is not in the appstore or where the appstore doesn't deliver the latest version
• this app has following dependency:

<dependencies>
	<nextcloud min-version="14" max-version="15" />
</dependencies>

• having Nextcloud 14 installed
• change to beta channel to get the update notification for 15
• expected: if the app has max version of 15 at least it is not listed in the section "apps missing updates"
• actual: it is listed in "apps missing updates"

cc @nickvergessen

[nextcloud-bot]

GitMate.io thinks possibly related issues are #4663 (Update with disabled app store), #977 (No Notification of app-Update when Update is incombatible ), #5188 (No update shown), #4018 (App Store not loading), and #5627 (Broken app update notification).

[skjnldsv]

Still happening?

[ghost]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

[MorrisJobke]

Still happening?

Yep.

[nickvergessen]

Throw here in place 1 instead of returning false and add a catch around place 2:

server/lib/private/Installer.php

Line 427 in caff102

return false;

server/apps/updatenotification/lib/Notification/BackgroundJob.php

Lines 164 to 167 in cb05782

	$update = $this->isUpdateAvailable($app);
	if ($update !== false) {
	$this->createNotifications($app, $update);
	}

[szaimen]

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

[nickvergessen]

Still happening