Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP coding style #12325

Closed
danopz opened this issue Nov 6, 2018 · 4 comments
Closed

PHP coding style #12325

danopz opened this issue Nov 6, 2018 · 4 comments

Comments

@danopz
Copy link

danopz commented Nov 6, 2018

I am curious if there is still any reason still to go with the PEAR coding standard?
This standard seems not maintained anymore and so there is no standard for new PHP syntax.

Are you still using it because of the mass of code or just prefer the PEAR one over the de facto PSR standards?

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10744 (Update help.php), #6784 (Php error?), #12225 (Cleanup Server.php), #8740 (PHP errors (libpng)), and #829 (copyright in version.php).

@MorrisJobke
Copy link
Member

Are you still using it because of the mass of code or just prefer the PEAR one over the de facto PSR standards?

I guess we just sticked to what is in place right now, because changing the whole style of everything makes "git research via git blame" just unnecessarily harder.

@rullzer @blizzz @nickvergessen @icewind1991 Opinions?

@blizzz
Copy link
Member

blizzz commented Nov 7, 2018

I agree with @MorrisJobke. I don't see the need to change it.

@ChristophWurst
Copy link
Member

Closing as we won't change the coding style in the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants