Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top-left logo reaches 1 px beyond the header #11372

Closed
go2sh opened this issue Sep 25, 2018 · 2 comments
Closed

Top-left logo reaches 1 px beyond the header #11372

go2sh opened this issue Sep 25, 2018 · 2 comments
Assignees
@weeman1337
Labels
design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@go2sh
Copy link
Contributor

go2sh commented Sep 25, 2018

The logo in the top-left corner has a absolute position of 1 px from top. With the 100% height it has the same heigth as the header and thus is shown 1 px beyond the header, if the logo has no space around it.

Example
I used the browser to zoom in as 1 px is hard to see. ;-)
@nextcloud-bot nextcloud-bot added the design Design, UI, UX, etc. label Sep 25, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #4647 (Use png for logo in email header), and #5413 (HTTP Range header support).

@splitt3r
Copy link
Contributor

A small padding around the logo would be great anyway.

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Sep 25, 2018
@weeman1337 weeman1337 self-assigned this Sep 26, 2018
@weeman1337 weeman1337 mentioned this issue Sep 26, 2018
Merged
@snyk-bot snyk-bot mentioned this issue Jul 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weeman1337 weeman1337

Labels
design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@go2sh @jancborchardt @splitt3r @weeman1337 @nextcloud-bot