From 5682d302c72ae42dfa16b068ad70fe312ed1ff9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Tue, 6 Nov 2018 09:06:24 +0100
Subject: [PATCH 1/3] Add grid toggle for every files view
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 apps/files/css/files.scss                             | 7 +++++++
 apps/files/js/filelist.js                             | 5 +++--
 apps/files/lib/Controller/ViewController.php          | 2 ++
 apps/files/list.php                                   | 5 +++--
 apps/files/recentlist.php                             | 8 ++++++++
 apps/files/simplelist.php                             | 8 ++++++++
 apps/files/templates/index.php                        | 8 ++++++++
 apps/files/templates/list.php                         | 8 --------
 apps/files/templates/recentlist.php                   | 2 +-
 apps/files/templates/simplelist.php                   | 2 +-
 apps/files_external/list.php                          | 8 ++++++++
 apps/files_external/templates/list.php                | 2 +-
 apps/files_sharing/css/public.scss                    | 1 +
 apps/files_sharing/lib/Controller/ShareController.php | 2 ++
 apps/files_sharing/list.php                           | 8 ++++++++
 apps/files_sharing/templates/list.php                 | 2 +-
 apps/files_sharing/templates/public.php               | 7 +++++++
 apps/files_trashbin/list.php                          | 8 ++++++++
 apps/files_trashbin/templates/index.php               | 2 +-
 19 files changed, 78 insertions(+), 17 deletions(-)

diff --git a/apps/files/css/files.scss b/apps/files/css/files.scss
index d6f9bd6131ebd..bc99790f5005a 100644
--- a/apps/files/css/files.scss
+++ b/apps/files/css/files.scss
@@ -55,6 +55,10 @@
 	position: relative;
 	width: 100%;
 	min-width: 250px;
+	// hide table if emptycontent is not hidden
+	#emptycontent:not(.hidden) ~ & {
+		display: none;
+	}
 }
 
 /* fit app list view heights */
@@ -982,6 +986,9 @@ table.dragshadow td.size {
 	margin: 0;
 	padding: 22px;
 	opacity: .5;
+	position: fixed;
+	right: 0;
+	z-index: 100;
 
 	&:hover,
 	&:focus,
diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js
index 9459a266ce9d7..b61b4ef8569de 100644
--- a/apps/files/js/filelist.js
+++ b/apps/files/js/filelist.js
@@ -331,9 +331,10 @@
 
 			this.$el.find('thead th .columntitle').click(_.bind(this._onClickHeader, this));
 
-			// Toggle for grid view
-			this.$showGridView = $('input#showgridview');
+			// Toggle for grid view, only register once
+			this.$showGridView = $('input#showgridview:not(.registered)');
 			this.$showGridView.on('change', _.bind(this._onGridviewChange, this));
+			this.$showGridView.addClass('registered');
 			$('#view-toggle').tooltip({placement: 'bottom', trigger: 'hover'});
 
 			this._onResize = _.debounce(_.bind(this._onResize, this), 250);
diff --git a/apps/files/lib/Controller/ViewController.php b/apps/files/lib/Controller/ViewController.php
index d91d3b9db4c53..3932b2b0a8e0c 100644
--- a/apps/files/lib/Controller/ViewController.php
+++ b/apps/files/lib/Controller/ViewController.php
@@ -257,6 +257,8 @@ public function index($dir = '', $view = '', $fileid = null, $fileNotFound = fal
 		$params['allowShareWithLink']          = $this->config->getAppValue('core', 'shareapi_allow_links', 'yes');
 		$params['defaultFileSorting']          = $this->config->getUserValue($user, 'files', 'file_sorting', 'name');
 		$params['defaultFileSortingDirection'] = $this->config->getUserValue($user, 'files', 'file_sorting_direction', 'asc');
+		$params['showgridview']				   = $this->config->getUserValue($user, 'files', 'show_grid', true);
+		$params['isIE']						   = \OCP\Util::isIE();
 		$showHidden                            = (bool) $this->config->getUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', false);
 		$params['showHiddenFiles']             = $showHidden ? 1 : 0;
 		$params['fileNotFound']                = $fileNotFound ? 1 : 0;
diff --git a/apps/files/list.php b/apps/files/list.php
index 23b94d9be20c6..7a5159cf38796 100644
--- a/apps/files/list.php
+++ b/apps/files/list.php
@@ -25,14 +25,15 @@
 $userSession = \OC::$server->getUserSession();
 // TODO: move this to the generated config.js
 $publicUploadEnabled = $config->getAppValue('core', 'shareapi_allow_public_upload', 'yes');
+
 $showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', true);
 $isIE = \OCP\Util::isIE();
 
 // renders the controls and table headers template
 $tmpl = new OCP\Template('files', 'list', '');
-$tmpl->assign('publicUploadEnabled', $publicUploadEnabled);
+
 // gridview not available for ie
 $tmpl->assign('showgridview', $showgridview && !$isIE);
-$tmpl->assign('isIE', $isIE);
+$tmpl->assign('publicUploadEnabled', $publicUploadEnabled);
 $tmpl->printPage();
 
diff --git a/apps/files/recentlist.php b/apps/files/recentlist.php
index 91a9bce06b564..c17f9d598bfb8 100644
--- a/apps/files/recentlist.php
+++ b/apps/files/recentlist.php
@@ -23,7 +23,15 @@
  */
 // Check if we are a user
 OCP\User::checkLoggedIn();
+$config = \OC::$server->getConfig();
+$userSession = \OC::$server->getUserSession();
+
+$showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', true);
+$isIE = \OCP\Util::isIE();
 
 $tmpl = new OCP\Template('files', 'recentlist', '');
 
+// gridview not available for ie
+$tmpl->assign('showgridview', $showgridview && !$isIE);
+
 $tmpl->printPage();
diff --git a/apps/files/simplelist.php b/apps/files/simplelist.php
index 1d61b397050d3..9515ec623634b 100644
--- a/apps/files/simplelist.php
+++ b/apps/files/simplelist.php
@@ -22,8 +22,16 @@
  */
 
 // TODO: move to handlebars
+$config = \OC::$server->getConfig();
+$userSession = \OC::$server->getUserSession();
+
+$showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', true);
+$isIE = \OCP\Util::isIE();
 
 // renders the controls and table headers template
 $tmpl = new OCP\Template('files', 'simplelist', '');
+
+// gridview not available for ie
+$tmpl->assign('showgridview', $showgridview && !$isIE);
 $tmpl->printPage();
 
diff --git a/apps/files/templates/index.php b/apps/files/templates/index.php
index b49684643bb52..69ad73f108139 100644
--- a/apps/files/templates/index.php
+++ b/apps/files/templates/index.php
@@ -1,6 +1,14 @@
 <?php /** @var $l \OCP\IL10N */ ?>
 <?php $_['appNavigation']->printPage(); ?>
 <div id="app-content">
+
+	<?php if (!$_['isIE']) { ?>
+		<input type="checkbox" class="hidden-visually" id="showgridview"
+			<?php if($_['showgridview']) { ?>checked="checked" <?php } ?>/>
+		<label id="view-toggle" for="showgridview" class="button <?php p($_['showgridview'] ? 'icon-toggle-filelist' : 'icon-toggle-pictures') ?>"
+			title="<?php p($l->t('Toggle grid view'))?>"></label>
+	<?php } ?>
+
 	<?php foreach ($_['appContents'] as $content) { ?>
 	<div id="app-content-<?php p($content['id']) ?>" class="hidden viewcontainer">
 	<?php print_unescaped($content['content']) ?>
diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php
index 2bc94ca7afb12..75dc2bee26f1d 100644
--- a/apps/files/templates/list.php
+++ b/apps/files/templates/list.php
@@ -24,13 +24,6 @@
 	<?php endif;?>
 	<input type="hidden" class="max_human_file_size"
 		   value="(max <?php isset($_['uploadMaxHumanFilesize']) ? p($_['uploadMaxHumanFilesize']) : ''; ?>)">
-	<!-- IF NOT IE, SHOW GRIDVIEW -->
-	<?php if (!$_['isIE']) { ?>
-	<input type="checkbox" class="hidden-visually" id="showgridview"
-		<?php if($_['showgridview']) { ?>checked="checked" <?php } ?>/>
-	<label id="view-toggle" for="showgridview" class="button <?php p($_['showgridview'] ? 'icon-toggle-filelist' : 'icon-toggle-pictures') ?>"
-		   title="<?php p($l->t('Toggle grid view'))?>"></label>
-	<?php } ?>
 </div>
 
 <div id="emptycontent" class="hidden">
@@ -44,7 +37,6 @@
 	<h2><?php p($l->t('No entries found in this folder')); ?></h2>
 	<p></p>
 </div>
-
 <table id="filestable" class="list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>" data-allow-public-upload="<?php p($_['publicUploadEnabled'])?>" data-preview-x="250" data-preview-y="250">
 	<thead>
 		<tr>
diff --git a/apps/files/templates/recentlist.php b/apps/files/templates/recentlist.php
index 4c269c20256d9..360b5c95ee40f 100644
--- a/apps/files/templates/recentlist.php
+++ b/apps/files/templates/recentlist.php
@@ -11,7 +11,7 @@
 	<p></p>
 </div>
 
-<table id="filestable" class="list-container view-grid">
+<table id="filestable" class="list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>">
 	<thead>
 	<tr>
 		<th id='headerName' class="hidden column-name">
diff --git a/apps/files/templates/simplelist.php b/apps/files/templates/simplelist.php
index a99607ea642de..9fd9c49c9c320 100644
--- a/apps/files/templates/simplelist.php
+++ b/apps/files/templates/simplelist.php
@@ -13,7 +13,7 @@
 	<h2><?php p($l->t('No entries found in this folder')); ?></h2>
 	<p></p>
 </div>
-<table id="filestable" class="list-container view-grid">
+<table id="filestable" class="list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>">
 	<thead>
 		<tr>
 			<th id='headerName' class="hidden column-name">
diff --git a/apps/files_external/list.php b/apps/files_external/list.php
index 35ad6e60447cf..a63475e78e69e 100644
--- a/apps/files_external/list.php
+++ b/apps/files_external/list.php
@@ -22,9 +22,17 @@
  */
 // Check if we are a user
 OCP\User::checkLoggedIn();
+$config = \OC::$server->getConfig();
+$userSession = \OC::$server->getUserSession();
+
+$showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', true);
+$isIE = \OCP\Util::isIE();
 
 $tmpl = new OCP\Template('files_external', 'list', '');
 
+// gridview not available for ie
+$tmpl->assign('showgridview', $showgridview && !$isIE);
+
 /* Load Status Manager */
 \OCP\Util::addStyle('files_external', 'external');
 \OCP\Util::addScript('files_external', 'statusmanager');
diff --git a/apps/files_external/templates/list.php b/apps/files_external/templates/list.php
index 20f97dd4c082f..04b7159cfe162 100644
--- a/apps/files_external/templates/list.php
+++ b/apps/files_external/templates/list.php
@@ -11,7 +11,7 @@
 
 <input type="hidden" name="dir" value="" id="dir">
 
-<table id="filestable" class="list-container view-grid">
+<table id="filestable" class="list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>">
 	<thead>
 		<tr>
 			<th id='headerName' class="hidden column-name">
diff --git a/apps/files_sharing/css/public.scss b/apps/files_sharing/css/public.scss
index 44b7e53d2075e..d1bdfe9162a4e 100644
--- a/apps/files_sharing/css/public.scss
+++ b/apps/files_sharing/css/public.scss
@@ -169,6 +169,7 @@ thead {
 	position: relative;
 	font-weight: 300;
 	font-size: 11px;
+	line-height: 11px;
 	overflow: hidden;
 	text-overflow: ellipsis;
 }
diff --git a/apps/files_sharing/lib/Controller/ShareController.php b/apps/files_sharing/lib/Controller/ShareController.php
index 1a92000a5f66a..9a8e1298f932e 100644
--- a/apps/files_sharing/lib/Controller/ShareController.php
+++ b/apps/files_sharing/lib/Controller/ShareController.php
@@ -367,6 +367,8 @@ public function showShare($path = ''): TemplateResponse {
 			$shareTmpl['folder'] = $folder->fetchPage();
 		}
 
+		$shareTmpl['showgridview'] = true;
+
 		$shareTmpl['hideFileList'] = $hideFileList;
 		$shareTmpl['shareOwner'] = $this->userManager->get($share->getShareOwner())->getDisplayName();
 		$shareTmpl['downloadURL'] = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.downloadShare', ['token' => $this->getToken()]);
diff --git a/apps/files_sharing/list.php b/apps/files_sharing/list.php
index d94d5625e8eab..590a3a1911e82 100644
--- a/apps/files_sharing/list.php
+++ b/apps/files_sharing/list.php
@@ -21,9 +21,17 @@
  */
 // Check if we are a user
 OCP\User::checkLoggedIn();
+$config = \OC::$server->getConfig();
+$userSession = \OC::$server->getUserSession();
+
+$showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', true);
+$isIE = \OCP\Util::isIE();
 
 $tmpl = new OCP\Template('files_sharing', 'list', '');
 
+// gridview not available for ie
+$tmpl->assign('showgridview', $showgridview && !$isIE);
+
 OCP\Util::addScript('files_sharing', 'app');
 OCP\Util::addScript('files_sharing', 'sharedfilelist');
 
diff --git a/apps/files_sharing/templates/list.php b/apps/files_sharing/templates/list.php
index de92037a56303..95ba9160a9f52 100644
--- a/apps/files_sharing/templates/list.php
+++ b/apps/files_sharing/templates/list.php
@@ -10,7 +10,7 @@
 	<h2><?php p($l->t('No entries found in this folder')); ?></h2>
 </div>
 
-<table id="filestable" class="list-container view-grid">
+<table id="filestable" class="list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>">
 	<thead>
 		<tr>
 			<th id='headerName' class="hidden column-name">
diff --git a/apps/files_sharing/templates/public.php b/apps/files_sharing/templates/public.php
index 4487e63f2dec0..08e119322e59e 100644
--- a/apps/files_sharing/templates/public.php
+++ b/apps/files_sharing/templates/public.php
@@ -45,6 +45,13 @@
 	</div>
 <?php endif; ?>
 
+<?php if (!$_['isIE']) { ?>
+	<input type="checkbox" class="hidden-visually" id="showgridview"
+		<?php if($_['showgridview']) { ?>checked="checked" <?php } ?>/>
+	<label id="view-toggle" for="showgridview" class="button <?php p($_['showgridview'] ? 'icon-toggle-filelist' : 'icon-toggle-pictures') ?>"
+		title="<?php p($l->t('Toggle grid view'))?>"></label>
+<?php } ?>
+
 <?php if (!isset($_['hideFileList']) || (isset($_['hideFileList']) && $_['hideFileList'] === false)) { ?>
 	<div id="files-public-content">
 		<div id="preview">
diff --git a/apps/files_trashbin/list.php b/apps/files_trashbin/list.php
index 77823617831ee..48ed7b694d045 100644
--- a/apps/files_trashbin/list.php
+++ b/apps/files_trashbin/list.php
@@ -24,8 +24,16 @@
 // Check if we are a user
 OCP\User::checkLoggedIn();
 
+$config = \OC::$server->getConfig();
+$userSession = \OC::$server->getUserSession();
+
+$showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', true);
+$isIE = \OCP\Util::isIE();
 
 $tmpl = new OCP\Template('files_trashbin', 'index', '');
+
+// gridview not available for ie
+$tmpl->assign('showgridview', $showgridview && !$isIE);
 OCP\Util::addStyle('files_trashbin', 'trash');
 OCP\Util::addScript('files_trashbin', 'app');
 OCP\Util::addScript('files_trashbin', 'filelist');
diff --git a/apps/files_trashbin/templates/index.php b/apps/files_trashbin/templates/index.php
index 054ffee61768b..e503e364af9c2 100644
--- a/apps/files_trashbin/templates/index.php
+++ b/apps/files_trashbin/templates/index.php
@@ -18,7 +18,7 @@
 	<p></p>
 </div>
 
-<table id="filestable" class="list-container view-grid">
+<table id="filestable" class="list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>">
 	<thead>
 		<tr>
 			<th id="headerSelection" class="hidden column-selection">

From 98edf3612c90aaec6fa18169feb60aede9e7ea45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Tue, 6 Nov 2018 11:45:19 +0100
Subject: [PATCH 2/3] Fix min trhumbnail size
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 apps/files/js/filelist.js          | 4 ++--
 apps/files_sharing/js/public.js    | 4 ++--
 apps/systemtags/templates/list.php | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js
index b61b4ef8569de..648a4f026419c 100644
--- a/apps/files/js/filelist.js
+++ b/apps/files/js/filelist.js
@@ -1953,10 +1953,10 @@
 		generatePreviewUrl: function(urlSpec) {
 			urlSpec = urlSpec || {};
 			if (!urlSpec.x) {
-				urlSpec.x = this.$table.data('preview-x') || 32;
+				urlSpec.x = this.$table.data('preview-x') || 250;
 			}
 			if (!urlSpec.y) {
-				urlSpec.y = this.$table.data('preview-y') || 32;
+				urlSpec.y = this.$table.data('preview-y') || 250;
 			}
 			urlSpec.x *= window.devicePixelRatio;
 			urlSpec.y *= window.devicePixelRatio;
diff --git a/apps/files_sharing/js/public.js b/apps/files_sharing/js/public.js
index 1dd9f5af6c731..2bd550a3b5c55 100644
--- a/apps/files_sharing/js/public.js
+++ b/apps/files_sharing/js/public.js
@@ -229,10 +229,10 @@ OCA.Sharing.PublicApp = {
 			this.fileList.generatePreviewUrl = function (urlSpec) {
 				urlSpec = urlSpec || {};
 				if (!urlSpec.x) {
-					urlSpec.x = this.$table.data('preview-x') || 32;
+					urlSpec.x = this.$table.data('preview-x') || 250;
 				}
 				if (!urlSpec.y) {
-					urlSpec.y = this.$table.data('preview-y') || 32;
+					urlSpec.y = this.$table.data('preview-y') || 250;
 				}
 				urlSpec.x *= window.devicePixelRatio;
 				urlSpec.y *= window.devicePixelRatio;
diff --git a/apps/systemtags/templates/list.php b/apps/systemtags/templates/list.php
index 841ce7b5b6ddb..252199d2fc489 100644
--- a/apps/systemtags/templates/list.php
+++ b/apps/systemtags/templates/list.php
@@ -13,7 +13,7 @@
 	<p></p>
 </div>
 
-<table id="filestable" data-preview-x="32" data-preview-y="32">
+<table id="filestable" data-preview-x="250" data-preview-y="250">
 	<thead>
 		<tr>
 			<th id='headerName' class="hidden column-name">

From cac2f7f4d69bfeeb0a1fbb011631593116a99518 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Tue, 6 Nov 2018 15:52:49 +0100
Subject: [PATCH 3/3] Fix tests
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 apps/files/tests/Controller/ViewControllerTest.php    | 11 +++++++----
 .../tests/Controller/ShareControllerTest.php          |  6 ++++--
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/apps/files/tests/Controller/ViewControllerTest.php b/apps/files/tests/Controller/ViewControllerTest.php
index f11a6faf8635e..35fc1e74c1a05 100644
--- a/apps/files/tests/Controller/ViewControllerTest.php
+++ b/apps/files/tests/Controller/ViewControllerTest.php
@@ -131,12 +131,13 @@ public function testIndexWithRegularBrowser() {
 				[$this->user->getUID(), 'files', 'file_sorting', 'name', 'name'],
 				[$this->user->getUID(), 'files', 'file_sorting_direction', 'asc', 'asc'],
 				[$this->user->getUID(), 'files', 'show_hidden', false, false],
+				[$this->user->getUID(), 'files', 'show_grid', true, true],
 			]));
 
-		$this->config
-			->expects($this->any())
-			->method('getAppValue')
-			->will($this->returnArgument(2));
+			$this->config
+				->expects($this->any())
+				->method('getAppValue')
+				->will($this->returnArgument(2));
 
 		$nav = new Template('files', 'appnavigation');
 		$nav->assign('usage_relative', 123);
@@ -366,6 +367,8 @@ public function testIndexWithRegularBrowser() {
 					],
 				],
 				'hiddenFields' => [],
+				'showgridview' => true,
+				'isIE' => false,
 			]
 		);
 		$policy = new Http\ContentSecurityPolicy();
diff --git a/apps/files_sharing/tests/Controller/ShareControllerTest.php b/apps/files_sharing/tests/Controller/ShareControllerTest.php
index c5306cbc0ce97..564977c09bcbf 100644
--- a/apps/files_sharing/tests/Controller/ShareControllerTest.php
+++ b/apps/files_sharing/tests/Controller/ShareControllerTest.php
@@ -288,7 +288,8 @@ public function testShowShare() {
 			'previewImage' => null,
 			'previewURL' => 'downloadURL',
 			'note' => $note,
-			'hideDownload' => false
+			'hideDownload' => false,
+			'showgridview' => true
 		);
 
 		$csp = new \OCP\AppFramework\Http\ContentSecurityPolicy();
@@ -407,7 +408,8 @@ public function testShowShareHideDownload() {
 			'previewImage' => null,
 			'previewURL' => 'downloadURL',
 			'note' => $note,
-			'hideDownload' => true
+			'hideDownload' => true,
+			'showgridview' => true
 		);
 
 		$csp = new \OCP\AppFramework\Http\ContentSecurityPolicy();