From 603d623d545f4f84d4f6a8c374ed2c54c4746b0a Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Mon, 29 Nov 2021 14:29:35 +0100
Subject: [PATCH] Interpolate the log message also for logged exceptions

According to PSR-3 the log message can have placeholders that are
replaced from the context object. Our logger implementation did that for
all PSR-3 logger methods. The only exception was our custom `logException`.

Since PsrLoggerAdapter calls logException when an exception key is
present in the context object, log messages were no longer interpolated.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
 lib/private/Log.php | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/lib/private/Log.php b/lib/private/Log.php
index db86aa8bfe3d5..3c3f22293d9cf 100644
--- a/lib/private/Log.php
+++ b/lib/private/Log.php
@@ -44,6 +44,7 @@
 use OCP\Log\IFileBased;
 use OCP\Log\IWriter;
 use OCP\Support\CrashReport\IRegistry;
+use function strtr;
 
 /**
  * logging utilities
@@ -207,13 +208,7 @@ public function log(int $level, string $message, array $context = []) {
 		array_walk($context, [$this->normalizer, 'format']);
 
 		$app = $context['app'] ?? 'no app in context';
-
-		// interpolate $message as defined in PSR-3
-		$replace = [];
-		foreach ($context as $key => $val) {
-			$replace['{' . $key . '}'] = $val;
-		}
-		$message = strtr($message, $replace);
+		$message = $this->interpolateMessage($context, $message);
 
 		try {
 			if ($level >= $minLevel) {
@@ -316,7 +311,7 @@ public function logException(\Throwable $exception, array $context = []) {
 
 		$serializer = new ExceptionSerializer($this->config);
 		$data = $serializer->serializeException($exception);
-		$data['CustomMessage'] = $context['message'] ?? '--';
+		$data['CustomMessage'] = $this->interpolateMessage($context, $context['message'] ?? '--');
 
 		$minLevel = $this->getLogLevel($context);
 
@@ -377,4 +372,20 @@ public function getLogPath():string {
 		}
 		throw new \RuntimeException('Log implementation has no path');
 	}
+
+	/**
+	 * Interpolate $message as defined in PSR-3
+	 *
+	 * @param array $context
+	 * @param string $message
+	 *
+	 * @return string
+	 */
+	private function interpolateMessage(array $context, string $message): string {
+		$replace = [];
+		foreach ($context as $key => $val) {
+			$replace['{' . $key . '}'] = $val;
+		}
+		return strtr($message, $replace);
+	}
 }