From 0cc692886b5db8f49c3a3ae9025f1ff4fadbfeda Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Tue, 21 May 2024 07:55:01 +0200
Subject: [PATCH] fix(auth): Update authtoken activity selectively

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
 lib/private/Authentication/Token/PublicKeyTokenProvider.php | 2 --
 lib/private/User/Session.php                                | 4 ++++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/private/Authentication/Token/PublicKeyTokenProvider.php b/lib/private/Authentication/Token/PublicKeyTokenProvider.php
index d4671bb6dacc6..bab025973b974 100644
--- a/lib/private/Authentication/Token/PublicKeyTokenProvider.php
+++ b/lib/private/Authentication/Token/PublicKeyTokenProvider.php
@@ -300,8 +300,6 @@ public function updateToken(IToken $token) {
 		if (!($token instanceof PublicKeyToken)) {
 			throw new InvalidTokenException("Invalid token type");
 		}
-		$now = $this->time->getTime();
-		$token->setLastActivity($now);
 		$this->mapper->update($token);
 		$this->cacheToken($token);
 	}
diff --git a/lib/private/User/Session.php b/lib/private/User/Session.php
index 458982315032d..90ae35584787a 100644
--- a/lib/private/User/Session.php
+++ b/lib/private/User/Session.php
@@ -45,6 +45,7 @@
 use OC\Authentication\Exceptions\PasswordLoginForbiddenException;
 use OC\Authentication\Token\IProvider;
 use OC\Authentication\Token\IToken;
+use OC\Authentication\Token\PublicKeyToken;
 use OC\Hooks\Emitter;
 use OC\Hooks\PublicEmitter;
 use OC_User;
@@ -772,6 +773,9 @@ private function checkTokenCredentials(IToken $dbToken, $token) {
 		}
 
 		$dbToken->setLastCheck($now);
+		if ($dbToken instanceof PublicKeyToken) {
+			$dbToken->setLastActivity($now);
+		}
 		$this->tokenProvider->updateToken($dbToken);
 		return true;
 	}