Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sharing Only with Confirmed E-Mail Address #15

Closed
mritzmann opened this issue May 7, 2020 · 4 comments · Fixed by #17
Closed

Allow Sharing Only with Confirmed E-Mail Address #15

mritzmann opened this issue May 7, 2020 · 4 comments · Fixed by #17
Labels
enhancement New feature or request

Comments

@mritzmann
Copy link

We rarely have problems with the public Nextcloud installation being used for propaganda purposes (e.g. ISIS videos) or for distributing viruses. The procedure is always the same:

  1. The user registers with a fake email address
  2. Uploads the malicious file and shares it publicly

This causes also many abuse messages, justifiably. After all: Since the e-mail address has not been confirmed, the account is automatically deactivated and the public share disappears. At least that's better than nothing. (This works since this issue was fixed: nextcloud/server#16302 Thanks!)

So my suggestion is this:

  • Only allow sharing once the email address has been confirmed. Sure, even so the installation can still be abused, but the effort is greater.

Not sure if this functionality can be covered by an app at all. But it would be a great option.

Or maybe there are other providers who have solved the problem already differently?

@MorrisJobke
Copy link
Member

cc @skjnldsv

@skjnldsv
Copy link
Member

Hey, I added a new feature.
Can you test #17?

Wit that you can then add the unconfirmed group(s) to the list of excluded groups from sharing (in the sharing settings)

@skjnldsv skjnldsv added the enhancement New feature or request label May 11, 2020
@mritzmann
Copy link
Author

mritzmann commented May 12, 2020

Just installed the preferred_providers app with the patch on a test installation.

git clone https://github.com/nextcloud/preferred_providers.git ~/www/apps/preferred_providers
cd  ~/www/apps/preferred_providers
git checkout enhancement/allow-groups-confirmed-unconfirmed
php ~/www/occ app:enable preferred_providers

But because the signup page makes an API request to https://nextcloud.com/wp-json/signup/account with a token, i'm not sure how to test this. I would not like to test it directly on the productive installation. Is there a simple curl command to play through a registration?

Otherwise based on the setting page it looks like the Pull Request does exactly what I need. :-)

@mritzmann
Copy link
Author

I tested it today and it works, thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants