Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid tabindex and role #2840

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix invalid tabindex and role #2840

merged 1 commit into from
Jul 14, 2022

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen commented Jul 14, 2022 •
edited
Loading

Bad value "" for attribute role on element div.

and

An element with the attribute tabindex must not appear as a descendant
of an element with the attribute role=button.

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Fix invalid tabindex and role
a4731ae 
Bad value "" for attribute role on element div.

An element with the attribute tabindex must not appear as a descendant
of an element with the attribute role=button.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 14, 2022
@nickvergessen nickvergessen added this to the 5.3.2 milestone Jul 14, 2022
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 14, 2022
@Pytal Pytal merged commit 510246b into master Jul 14, 2022
@Pytal Pytal deleted the bugfix/noid/remove-invalid-tabindex-and-role branch July 14, 2022 17:59
@juliusknorr juliusknorr modified the milestones: 5.3.2, 6.0.0 Aug 2, 2022
@juliusknorr juliusknorr mentioned this pull request Aug 2, 2022
Closed
@nickvergessen
Copy link
Contributor Author

/backport to stable5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 2, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @Pytal @marcoambrosini @juliusknorr