Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow material design icons in AppSidebarTab #1939

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented May 7, 2021

This PR implements material design icons in the AppSidebarTabs header. The icon is not gray anymore when focused, which I think makes sense, as the text is black as well.

Before
Screenshot_2021-05-08 Nextcloud Vue Style Guide(1)

After (sharing icon is provided by string):
Screenshot_2021-05-08 Nextcloud Vue Style Guide

Closes #1859.

@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels May 7, 2021
@raimund-schluessler raimund-schluessler added this to the 4.0.0 milestone May 7, 2021
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow material-design-icons in AppSidebarTabs
3 participants