Wrap icon span in icon slot for ActionButton #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
added
bug
raimund-schluessler
requested review from
marcoambrosini,
skjnldsv and
juliusknorr
skjnldsv
approved these changes
May 6, 2021
marcoambrosini
approved these changes
May 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the icon span into the icon slot for the
ActionButtoncomponent. This aligns it with the other Actionsand prevents setting a background icon and providing an material design icon via slot.Nevermind, I just realized you can still provide a material design icon and have an icon set at the background.But at least, this PR aligns it with how the other Action components handle it.
Closes #1925