Update appnavigationcaption #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
added
2. developing
marcoambrosini
requested review from
jancborchardt,
juliusknorr,
korelstar and
skjnldsv
Closed
marcoambrosini
force-pushed
the
update-appnavigationcaption
branch
from
ef7e004
to
75b9ac9
Compare
marcoambrosini
added
3. to review
skjnldsv
reviewed
Apr 19, 2021
|
Also I'm realizing that this component is missing copyright and docs section. @korelstar I can't find a copyright from you in the codebase, is that a deliberate choice? |
jancborchardt
approved these changes
Apr 19, 2021
marcoambrosini
force-pushed
the
update-appnavigationcaption
branch
from
75b9ac9
to
b659458
Compare
|
Added docs and actions component |
marcoambrosini
force-pushed
the
update-appnavigationcaption
branch
from
b659458
to
265d877
Compare
skjnldsv
reviewed
Apr 19, 2021
skjnldsv
reviewed
Apr 20, 2021
This is just because I didn't think it reaches the threshold of originality ("Schöpfungshöhe" in German) and because I don't like copyright headers. 😉 |
marcoambrosini
force-pushed
the
update-appnavigationcaption
branch
from
265d877
to
ba4e8b8
Compare
skjnldsv
reviewed
Apr 21, 2021
skjnldsv
approved these changes
Apr 21, 2021
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
marcoambrosini
force-pushed
the
update-appnavigationcaption
branch
from
ba4e8b8
to
140c277
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates the design of the
AppNavigationCaptioncomponent and adds the ability to slot actions in it.Signed-off-by: Marco Ambrosini marcoambrosini@pm.me