Actions forward focus and blur events on trigger #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the trigger of a single action item or the trigger of an action menu is focussed or blurred, re-emit the event on the Action component for outside processing. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
requested review from
ChristophWurst,
juliusknorr,
skjnldsv and
marcoambrosini
PVince81
added
3. to review
This was referenced Mar 11, 2021
marcoambrosini
approved these changes
Mar 12, 2021
ChristophWurst
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the trigger of a single action item or the trigger of an action
menu is focussed or blurred, re-emit the event on the Action component
for outside processing.
Fixes #1617
Can be seen in use in nextcloud/spreed#4666 where we need to track whether a button is focussed to prevent removing the hover and preventing to hide the buttons there.