Add tooltips in app sidebar header #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added nicer looking tooltip for the close button. Added optional tooltip for the app sidebar header. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
added
enhancement
3 tasks
|
here's the talk PR: nextcloud/spreed#4551 |
ChristophWurst
approved these changes
Nov 9, 2020
|
/backport to stable2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nicer looking tooltip for the close button.
Added optional tooltip for the app sidebar header.
Tested with Talk where I locally set the titleTolltip property to the same value as the title:
And the close button:
I didn't want to make it default to the title as it might not always look good depending on use case.
In the case of the Talk app, the title is a user defined room name.
For other apps it might be static text that doesn't ellipsize nor needs a tooltip.