Bump css-loader from 3.6.0 to 5.0.0 #1537

dependabot · 2020-11-02T11:53:39Z

Bumps css-loader from 3.6.0 to 5.0.0.

Release notes

v5.0.0

⚠ BREAKING CHANGES

migrate on PostCSS 8

runtime doesn't contain source maps code without sourceMap: true

returned value from the getLocalIdent escapes by default, the exportName value is always unescaped

Auto enable icss modules for all files for which /\.icss\.\w+$/i is true (the modules.compileType option is icss)

[emoji] placeholder was deprecated

the icss option was removed (it was deprecated previously)

Features

allowed named exports to have underscores in names (#1209) (747d62b)

no warnings when you don't need handle url()/@import (#1195) (dd52931)

improved error message (52412f6)

reduced runtime (9f974be)

added fallback if custom getLocalIdent returns null/undefined (#1193) (0f95841)

v4.3.0

4.3.0 (2020-09-08)

Features

the importLoaders option can be string (#1178) (ec58a7c)

Bug Fixes

line breaks in the url function (88b8ddc)

v4.2.2

4.2.2 (2020-08-24)

Bug Fixes

source maps generation, source from source maps are now relative to compiler.context and use webpack:// protocol (#1169) (fb5c53d)

v4.2.1

4.2.1 (2020-08-06)

Bug Fixes

regression with the exportOnlyLocals option, now locals are not exported under the locals name, it was big regression, we apologize for that (24c0a12)

v4.2.0

4.2.0 (2020-07-31)

... (truncated)

Changelog

Sourced from css-loader's changelog.

5.0.0 (2020-10-13)

⚠ BREAKING CHANGES

migrate on PostCSS 8

runtime doesn't contain source maps code without sourceMap: true

returned value from the getLocalIdent escapes by default, the exportName value is always unescaped

Auto enable icss modules for all files for which /\.icss\.\w+$/i (the modules.compileType option is icss)

[emoji] placeholder was deprecated

icss option was removed (it was deprecated previously)

Features

allow named exports to have underscores in names (#1209) (747d62b)

hide warning when you don't need handle url()/@import (#1195) (dd52931)

improve error message (52412f6)

reduce runtime (9f974be)

add fallback if custom getLocalIdent returns null/undefined (#1193) (0f95841)

4.3.0 (2020-09-08)

Features

the importLoaders can be string (#1178) (ec58a7c)

Bug Fixes

line breaks in url function (88b8ddc)

4.2.2 (2020-08-24)

Bug Fixes

source maps generation, source from source maps are now relative to compiler.context and use webpack:// protocol (#1169) (fb5c53d)

4.2.1 (2020-08-06)

Bug Fixes

regression with the exportOnlyLocals option, now locals are not exported under the locals name, it was big regression, we apologize for that (24c0a12)

4.2.0 (2020-07-31)

Features

... (truncated)

Commits

1351e3a chore(release): 5.0.0
747d62b feat: allow named exports to have underscores in names (#1209)
7bfe85d chore(deps): update (#1208)
b5c9379 feat: postcss@8 (#1204)
92fe103 docs: context is localIdentContext in README (#1202)
e5a9272 chore(deps): update (#1203)
63b41be refactor: emoji deprecate
9f974be feat: reduce runtime
d779eb1 feat: escape getLocalIdent by default (#1196)
dd52931 feat: hide warning on no plugins (#1195)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

skjnldsv · 2020-11-02T14:29:39Z

@raimund-schluessler I'm stuck!
I updated our server styling, which differs a bit. So I wanted to update the cypress snapshots pics.
Somehow it still doesn't pass... 😢

raimund-schluessler · 2020-11-02T14:41:07Z

@skjnldsv Have you checked the diffs, for the reason why it is not passing?

raimund-schluessler · 2020-11-02T14:43:08Z

Your new base images seem to contain a long number, in difference to the previous ones. Maybe this is problematic as well!?

skjnldsv · 2020-11-02T14:52:48Z

Your new base images seem to contain a long number, in difference to the previous ones. Maybe this is problematic as well!?

right weird. let me check

skjnldsv · 2020-11-02T19:17:17Z

right weird. let me check

so it does generate weird stuff, but the issue was the spellcheck conf that changed 🤷
The font changed on server though, and I can't get the font to be the same, dammit!

dependabot · 2020-11-05T04:09:26Z

A newer version of css-loader exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

skjnldsv · 2020-11-05T07:01:38Z

cc @juliushaertl since you worked on the old pr

Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.6.0 to 5.0.0. - [Release notes](https://github.com/webpack-contrib/css-loader/releases) - [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/css-loader@v3.6.0...v5.0.0) Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv · 2020-11-05T15:51:01Z

I got it!! 🚀
So it seems like the font is still causing issues, but I cleaned that up and if you download the artefacts on a failed one, you can update the base snapshots from the one the github runner generated.

You have to rename each file though they each contain actual instead of base, renaming the actual folder isn't enough 😓

raimund-schluessler · 2020-11-05T16:04:56Z

So it seems like the font is still causing issues, but I cleaned that up and if you download the artefacts on a failed one, you can update the base snapshots from the one the github runner generated.

But I guess the tests won't pass locally then anymore, no?

Edit: I just tested it and the cypress tests now fail locally💣 I doubt that this is wanted behaviour since you will only know if your tests pass after you pushed. Especially for a visual test with possibly lots of tinkering this seems cumbersome, since you have to wait even longer for the remote tests than you would have to wait for local tests. And with the limited runner minutes on netlify this also seems not so great 😉

skjnldsv · 2020-11-05T16:27:06Z

But I guess the tests won't pass locally then anymore, no?

They never did ^^
Not on a single pr I worked with 🤷

skjnldsv · 2020-11-05T16:27:21Z

At least I couldn't find a commit where it worked :(
But 100% agree, not super great. We need to fix this font issue!

raimund-schluessler · 2020-11-05T16:42:59Z

But I guess the tests won't pass locally then anymore, no?

They never did ^^

Not on a single pr I worked with 🤷

Weird, for me it worked until now.
We could still run the tests in a docker container also locally 😉 🙈

dependabot bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Nov 2, 2020

github-actions bot approved these changes Nov 2, 2020

View reviewed changes

skjnldsv force-pushed the dependabot/npm_and_yarn/css-loader-5.0.0 branch from 9c7e136 to d4cda74 Compare November 2, 2020 12:03

skjnldsv approved these changes Nov 2, 2020

View reviewed changes

skjnldsv force-pushed the dependabot/npm_and_yarn/css-loader-5.0.0 branch 6 times, most recently from a43e1a0 to 7858cac Compare November 2, 2020 14:00

skjnldsv force-pushed the dependabot/npm_and_yarn/css-loader-5.0.0 branch 5 times, most recently from 2563f9e to 22da34d Compare November 2, 2020 19:11

skjnldsv force-pushed the dependabot/npm_and_yarn/css-loader-5.0.0 branch from 22da34d to 2a3bf42 Compare November 5, 2020 15:39

Bump cypress config and split into two specs

d6faa33

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv force-pushed the dependabot/npm_and_yarn/css-loader-5.0.0 branch from 2a3bf42 to d6faa33 Compare November 5, 2020 15:45

skjnldsv merged commit 77ef725 into master Nov 5, 2020

skjnldsv deleted the dependabot/npm_and_yarn/css-loader-5.0.0 branch November 5, 2020 15:52

This was referenced Mar 28, 2021

Fix compact sidebar subtitle not visible #1767

Merged

Title text is moving when enabling edit mode #1790

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump css-loader from 3.6.0 to 5.0.0 #1537

Bump css-loader from 3.6.0 to 5.0.0 #1537

dependabot bot commented on behalf of github Nov 2, 2020 •

edited by skjnldsv

Loading

skjnldsv commented Nov 2, 2020

raimund-schluessler commented Nov 2, 2020

raimund-schluessler commented Nov 2, 2020

skjnldsv commented Nov 2, 2020

skjnldsv commented Nov 2, 2020 •

edited

Loading

dependabot bot commented on behalf of github Nov 5, 2020

skjnldsv commented Nov 5, 2020

skjnldsv commented Nov 5, 2020

raimund-schluessler commented Nov 5, 2020 •

edited

Loading

skjnldsv commented Nov 5, 2020

skjnldsv commented Nov 5, 2020 •

edited

Loading

raimund-schluessler commented Nov 5, 2020

Bump css-loader from 3.6.0 to 5.0.0 #1537

Bump css-loader from 3.6.0 to 5.0.0 #1537

Conversation

dependabot bot commented on behalf of github Nov 2, 2020 • edited by skjnldsv Loading

v5.0.0

⚠ BREAKING CHANGES

Features

v4.3.0

4.3.0 (2020-09-08)

Features

Bug Fixes

v4.2.2

4.2.2 (2020-08-24)

Bug Fixes

v4.2.1

4.2.1 (2020-08-06)

Bug Fixes

v4.2.0

4.2.0 (2020-07-31)

5.0.0 (2020-10-13)

⚠ BREAKING CHANGES

Features

4.3.0 (2020-09-08)

Features

Bug Fixes

4.2.2 (2020-08-24)

Bug Fixes

4.2.1 (2020-08-06)

Bug Fixes

4.2.0 (2020-07-31)

Features

skjnldsv commented Nov 2, 2020

raimund-schluessler commented Nov 2, 2020

raimund-schluessler commented Nov 2, 2020

skjnldsv commented Nov 2, 2020

skjnldsv commented Nov 2, 2020 • edited Loading

dependabot bot commented on behalf of github Nov 5, 2020

skjnldsv commented Nov 5, 2020

skjnldsv commented Nov 5, 2020

raimund-schluessler commented Nov 5, 2020 • edited Loading

skjnldsv commented Nov 5, 2020

skjnldsv commented Nov 5, 2020 • edited Loading

raimund-schluessler commented Nov 5, 2020

dependabot bot commented on behalf of github Nov 2, 2020 •

edited by skjnldsv

Loading

skjnldsv commented Nov 2, 2020 •

edited

Loading

raimund-schluessler commented Nov 5, 2020 •

edited

Loading

skjnldsv commented Nov 5, 2020 •

edited

Loading