Adapt to new vue2-datepicker format props #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g) and formatter (object) Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
added
bug
GretaD
approved these changes
Oct 26, 2020
How could we release this as a minor change? This is breaking Calendar in nextcloud/calendar#2700
|
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting vue2-datepicker 3.7.0 and since 3.6.3, the
formatprop not a string/object anymore. It's now just a string and there is a newformatterobject prop.As there is no default for this prop in vue2-datepicker, I wonder if it's better to have
{}ornullas default in@nc/vue