Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show letter if we have an icon and keep image ratio #1501

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Do not show letter if we have an icon and keep image ratio #1501

merged 1 commit into from
Oct 21, 2020

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Oct 21, 2020 •
edited
Loading

Before After
dev skjnldsv com_apps_contacts_ (3) dev skjnldsv com_apps_contacts_ (2)
Capture d’écran_2020-10-21_09-05-28 Capture d’écran_2020-10-21_09-05-34

@nextcloud/vuejs

@skjnldsv
Do not show letter if we have an icon and keep image ratio
1d14088 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: avatar Related to the avatar component labels Oct 21, 2020
@skjnldsv skjnldsv self-assigned this Oct 21, 2020
ChristophWurst
ChristophWurst approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

christoph .review {
    css-comprehension: none
}

@ChristophWurst ChristophWurst merged commit 1586c93 into master Oct 21, 2020
@ChristophWurst ChristophWurst deleted the fix/avatar-icon branch October 21, 2020 07:32
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 5, 2020 

christoph .review {
    css-comprehension: none
}

You're hired!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@call-me-matt call-me-matt Awaiting requested review from call-me-matt

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: avatar Related to the avatar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @ChristophWurst @marcoambrosini